Skip to content

fix: preserve reasoning across provider steps - #2249

Merged
Astro-Han merged 2 commits into
apache:mainfrom
Astro-Han:fix/runtime-reasoning-continuity
Aug 5, 2026
Merged

fix: preserve reasoning across provider steps#2249
Astro-Han merged 2 commits into
apache:mainfrom
Astro-Han:fix/runtime-reasoning-continuity

Conversation

@Astro-Han

Copy link
Copy Markdown
Contributor

Summary

  • resolve each model runtime wire and reasoning replay contract once, then share that decision across model construction, execution, and connection probes
  • generalize OpenAI Chat reasoning capture/replay from Kimi to compatible providers while preserving the observed reasoning or reasoning_content field and legacy persisted metadata
  • keep Anthropic signed thinking, OpenAI Responses items/continuation, Gemini metadata, and structured reasoning_details on their existing protocol-specific paths

Closes #2241

Verification

  • npm --workspace @maka/runtime test (3203 tests, 0 failures, 9 skipped)
  • npm run lint
  • npm run format:check
  • focused durable DeepSeek Chat replay, shared runtime-contract, and DeepSeek Responses probe tests
  • npm run build and npm run typecheck reach existing desktop protocol type errors also reproducible on the unchanged main checkout; all preceding affected workspaces build/typecheck successfully

@Astro-Han
Astro-Han marked this pull request as ready for review August 5, 2026 14:04
@Astro-Han
Astro-Han merged commit 6c56430 into apache:main Aug 5, 2026
12 checks passed
@Astro-Han
Astro-Han deleted the fix/runtime-reasoning-continuity branch August 5, 2026 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(runtime): round-trip reasoning_content on every openai-chat connection, not just kimi-coding-plan

1 participant