fix(daily-review): cap analysis-model Select width + right-align quick-run buttons - #227
Merged
Merged
Conversation
…k-run buttons WAWQAQ msg `0951e3b1` + `3871e56b` 2026-06-25, two related bugs in the Daily Review surfaces: ## #2 — 分析模型 Select 特别长 `.settingsRow` is a 2-column grid `minmax(150px, 0.36fr) 1fr`. On a wide settings page the right control column can be 500px+. With `w-full` on the `<SelectTrigger>`, the dropdown stretched the entire right column — hence "特别长，完全就不对". Fix: add a `.settingsRow > .settingsBaseSelectTrigger` rule that caps `max-width: 320px` and `justify-self: end`, mirroring the existing `.settingsField[data-orient="horizontal"]` rule that already caps inputs on the parallel horizontal-row layout. The Select now visually sits in the same right-edge position as the Switch toggles in adjacent rows. ## #3 — 生成 buttons 直接靠近文本 `.maka-daily-review-quick-runs` was `display: flex` with no `justify-content`, so the 生成每日回顾 / 生成深度分析 buttons sat flex-start (left-aligned), hugging the explanatory paragraph directly above them. Fix: `justify-content: flex-end` pushes them right, matching the panel's right-action convention (the 复制 / 粘到 / 保存 row below already sits right via its `1fr auto` grid). ## Diff 1 file, +18 / -1. CSS-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WAWQAQ msg `0951e3b1` + `3871e56b` 2026-06-25, two Daily Review bugs.
#2 — Settings → 每日回顾 → 分析模型 Select 特别长
`.settingsRow` is a grid `minmax(150px, 0.36fr) 1fr`. With `w-full` on the trigger the dropdown stretched the full right column (~500px+ on a wide settings page) → "特别长".
Fix: add `.settingsRow > .settingsBaseSelectTrigger { max-width: 320px; justify-self: end; }` — mirrors the existing horizontal-field cap and right-aligns the trigger to match Switches in adjacent rows.
#3 — 每日回顾 panel 生成 buttons 靠近文本
`.maka-daily-review-quick-runs` was flex with no `justify-content`. 生成每日回顾 / 生成深度分析 sat left-aligned, hugging the paragraph above. "按道理一般都是在右边".
Fix: `justify-content: flex-end`. Matches the panel's right-action convention (the 复制 / 粘到 / 保存 row below is already right via its `1fr auto` grid).
Diff
`1 file, +18 / -1`. CSS-only.