fix(settings): drop daily-review hero card pile + semantic width attr (kenji #5+#6) - #244
Merged
Merged
Conversation
Bundled response to @kenji audit findings #5 + #6 (msg `26a221be`) plus the page-restructure WAWQAQ explicitly authorized (thread msg `afbe542d`: 「一次性多改,别他妈分这么多轮」). **Finding #6 — Daily Review settings page restructure.** Removed the two `.settingsFeatureStatusHero` cards (intro + 「想先看看 效果?」). They were promo chrome on a workbench settings surface and duplicated information the section banner already carries. The 「打开每日回顾」 / 「生成每日回顾」 / 「生成深度分析」 actions are now folded into a single right-aligned `.settingsPageFooterActions` toolbar rendered below the rows. Net: one banner, one grouped rows surface, one action footer — no card pile. The `.settingsFeatureStatusHero*` CSS rules stay because the voice settings page still uses them; this PR just drops Daily Review's dependency on them. **Finding #5 — semantic width attr instead of class-selector patches.** `.settingsRow > .settingsTimeInput` and `.settingsRow > .settingsBaseSelectTrigger` were globally-scoped selectors that implicitly assumed the row contained one specific control type. Move the contract to a `data-control-width="compact| select"` attribute on the row itself; mark the 执行时间 and 分析模型 rows accordingly. The old global rules are gone — only the data-attr rules survive. Verified the 4 other `SettingsSelect` call sites (proxy host, gateway host, bot domain, usage filter) are inside `.settingsField`, not `.settingsRow`, so they aren't affected by the dropped rule.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bundled response to @kenji audit findings #5 + #6 (msg `26a221be`) plus the structural cleanup WAWQAQ authorized in msg `afbe542d` ("一次性多改,别他妈分这么多轮").
#6 — Daily Review hero card pile collapsed.
Removed the intro hero card ("每日回顾 · 本地 + LLM" with paragraph + 「打开每日回顾」 button) and the bottom "想先看看效果?" hero card (paragraph + 2 generate buttons). The page now reads as:
.settingsPageFooterActionstoolbar with all three actions (打开每日回顾 · 生成每日回顾 · 生成深度分析)The
.settingsFeatureStatusHero*CSS rules survive because the voice settings page still uses them.#5 — semantic width attr.
.settingsRow > .settingsTimeInput→.settingsRow[data-control-width=\"compact\"] > input, .settingsRow[data-control-width=\"compact\"] > .settingsTimeInput.settingsRow > .settingsBaseSelectTrigger→.settingsRow[data-control-width=\"select\"] > .settingsBaseSelectTriggerdata-control-width=\"compact\", 分析模型 row getsdata-control-width=\"select\". The contract is now declared on the row, not implicit in the control's class name.Verified the 4 other
SettingsSelectcall sites (proxy host, gateway host, bot domain, usage filter) are inside.settingsField, not.settingsRow, so dropping the old global rule does not affect them.Test plan
data-control-widthon their row, not from class selectors..settingsField, not.settingsRow, and use the.settingsField[data-orient=\"horizontal\"]width contract instead.