fix(desktop): keep task menu interactive while open - #3114
Conversation
Keep the task row action host pointer-interactive for the native popover's full open lifetime so the chat surface cannot intercept menu item clicks. Add an Electron pointer regression covering the rename action. Generated-by: Codex
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan includes up to 3 reviews per rolling hour; 2 remain after this review. 📝 WalkthroughSummary
Design and scope
Simplification
Validation
Review-relevant risks
WalkthroughThe sidebar action menu now stays visible while its native popover is open. An end-to-end test opens the menu with pointer input, selects “重命名,” and verifies the task rename dialog. ChangesSidebar action-menu interaction
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The change keeps task action menus interactive while open and includes focused regression coverage; no actionable merge-blocking risk remains after normal checks and review. Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Fast path rationale: this PR is a low-impact, narrowly scoped fix that restores the existing task-menu pointer behavior. It changes one CSS hit-testing rule, adds a focused Electron regression test, is easy to revert, and does not touch public contracts, security, licensing, releases, governance, or Runtime architecture boundaries. Human contributor @Astro-Han reviewed the final diff and chose the self-merge fast path. Required checks must pass before merge. AI-assisted implementation: Codex diagnosed the regression, authored the fix and regression test, and ran the reported verification. The human contributor verified the final diff and owns the merge decision. — Posted by Codex at @Astro-Han's direction. |
Summary
Fix task row action menus whose visible native popover stopped accepting pointer clicks after the cursor left the row. Keep the action host pointer-interactive for the full popover-open lifetime so the underlying chat surface cannot intercept menu item clicks.
Verification
Root cause
The hover-only task action host returned to pointer-events: none while its native popover remained visibly open in the top layer. That value made hit testing fall through the menu to the chat surface underneath. The open popover is now an additional authority for keeping the host interactive.
AI use
Select exactly one:
Tool(s) and scope: Codex diagnosed the pointer hit-testing regression, authored the CSS fix and Electron regression test, and ran the reported verification.
Checklist
Does this PR entail a change in behavior?