Skip to content

fix(desktop): import Plan Mode copy types from core subpaths - #3119

Merged
Astro-Han merged 1 commit into
apache:mainfrom
1625567290:fix/desktop-plan-mode-copy-core-subpath
Aug 16, 2026
Merged

fix(desktop): import Plan Mode copy types from core subpaths#3119
Astro-Han merged 1 commit into
apache:mainfrom
1625567290:fix/desktop-plan-mode-copy-core-subpath

Conversation

@1625567290

Copy link
Copy Markdown
Contributor

Summary

main is currently red after #2688. Plan Mode locale types import the removed @maka/core root barrel:

import type { PlanExecutionStep, PlanProposal, UiCatalog, UiLocale } from '@maka/core';

@maka/core no longer has a . export (see #3094). Desktop main typecheck follows src/main/__tests__/plan-mode-copy.test.ts into that renderer file and fails with TS2307: Cannot find module '@maka/core'. That cascades to typecheck, test_workspaces, test_runtime_host, test, e2e, and windows_recovery on every PR merged with current main.

Other locale catalogs already use the live subpaths. This PR matches them:

import type { PlanExecutionStep, PlanProposal } from '@maka/core/plan';
import type { UiCatalog, UiLocale } from '@maka/core/ui-locale';

Test plan

  • @maka/desktop typecheck (preload / main / renderer / storybook)
  • plan-mode-copy official node:test 1/1

Generated-by: Grok

apache#2688 imported Plan Mode locale types from the removed @maka/core root
barrel. Other locale catalogs already use @maka/core/ui-locale and
@maka/core/plan. The root import breaks desktop main typecheck and
cascades through every PR that merges with main.

Generated-by: Grok
@coderabbitai

coderabbitai Bot commented Aug 16, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 68e82a70-b2d4-40db-9abf-e48faee19bcc

📥 Commits

Reviewing files that changed from the base of the PR and between f6632ce and 03ae910.

📒 Files selected for processing (1)
  • apps/desktop/src/renderer/locales/plan-mode-copy.ts

Included review availability: Your plan includes up to 3 reviews per rolling hour; 0 remain after this review.


📝 Walkthrough

Summary

  • Fixes the desktop Plan Mode typecheck failure.
  • Replaces the removed @maka/core root type import with the available @maka/core/plan and @maka/core/ui-locale subpaths.
  • Extends the existing module source of truth. It does not add a parallel implementation path.
  • This is the smallest coherent solution. It changes one import statement and adds no runtime logic or public declarations.
  • No code or tests can be removed without reducing regression coverage.

Validation

  • Desktop typecheck.
  • plan-mode-copy test.
  • Required check results remain unverified without direct CI evidence.

Review-relevant risks

No protected-area effect was identified in the current diff. The change affects type imports only and has no apparent user-visible behavior, public contract, security, licensing, release, or governance impact. The person performing the merge reviews the final diff, and a maintainer makes the final determination.

Walkthrough

The plan mode locale file now imports plan and UI locale types from their dedicated @maka/core modules.

Changes

Plan mode locale imports

Layer / File(s) Summary
Dedicated type imports
apps/desktop/src/renderer/locales/plan-mode-copy.ts
Replaces the consolidated @maka/core type import with dedicated imports for plan and UI locale types.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 03ae9

This is a localized type-import correction for Plan Mode copy types, with no actionable merge-blocking risk remaining after normal checks and review.

Suggested reviewers: me2seeks

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the problem and solution and lists validation, but it omits the required AI use selection and checklist. Select the applicable AI use option, provide the tool scope, and complete the required checklist fields.
Ai Use Disclosure ⚠️ Warning The PR description selects neither AI-use option or scope, while its introduced commit contains the standalone trailer Generated-by: Grok. Select exactly one AI-use declaration and name Grok and its scope if applicable. See “Human ownership and AI attribution” in CONTRIBUTING.md; preserve the trailer through squash or amend.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the desktop import fix and names the affected Plan Mode copy types.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@Astro-Han

Copy link
Copy Markdown
Contributor

Fast path self-merge: this change is low impact and easy to reverse — a one-line import fix with no behavioral change, no public contract, security, licensing, or governance surface. Required checks pass (typecheck, test_workspaces, e2e, test, storybook, windows_recovery). The human contributor @yuhan reviewed the final diff and chose the fast path.

@Astro-Han
Astro-Han merged commit 802fe89 into apache:main Aug 16, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants