fix(desktop): import Plan Mode copy types from core subpaths - #3119
Conversation
apache#2688 imported Plan Mode locale types from the removed @maka/core root barrel. Other locale catalogs already use @maka/core/ui-locale and @maka/core/plan. The root import breaks desktop main typecheck and cascades through every PR that merges with main. Generated-by: Grok
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan includes up to 3 reviews per rolling hour; 0 remain after this review. 📝 WalkthroughSummary
Validation
Review-relevant risksNo protected-area effect was identified in the current diff. The change affects type imports only and has no apparent user-visible behavior, public contract, security, licensing, release, or governance impact. The person performing the merge reviews the final diff, and a maintainer makes the final determination. WalkthroughThe plan mode locale file now imports plan and UI locale types from their dedicated ChangesPlan mode locale imports
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This is a localized type-import correction for Plan Mode copy types, with no actionable merge-blocking risk remaining after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Fast path self-merge: this change is low impact and easy to reverse — a one-line import fix with no behavioral change, no public contract, security, licensing, or governance surface. Required checks pass (typecheck, test_workspaces, e2e, test, storybook, windows_recovery). The human contributor @yuhan reviewed the final diff and chose the fast path. |
Summary
mainis currently red after #2688. Plan Mode locale types import the removed@maka/coreroot barrel:@maka/coreno longer has a.export (see #3094). Desktop main typecheck followssrc/main/__tests__/plan-mode-copy.test.tsinto that renderer file and fails withTS2307: Cannot find module '@maka/core'. That cascades totypecheck,test_workspaces,test_runtime_host,test,e2e, andwindows_recoveryon every PR merged with currentmain.Other locale catalogs already use the live subpaths. This PR matches them:
Test plan
@maka/desktoptypecheck (preload / main / renderer / storybook)plan-mode-copyofficial node:test1/1Generated-by: Grok