fix(desktop): archive child sessions when parent is deleted - #3151
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (9)
💤 Files with no reviewable changes (2)
🚧 Files skipped from review as they are similar to previous changes (4)
Included review availability: Your plan includes up to 3 reviews per rolling hour; 2 remain after this review. 📝 WalkthroughProblem solvedWhen a parent Session is deleted, ordinary child subagent Sessions are archived instead of remaining as top-level tasks or being deleted. Archived children remain accessible and show The change also:
Design and source of truthThe PR extends the existing Session retirement and SQLite metadata paths. It does not create a parallel deletion or archival path.
Scope and complexityThis is the smallest coherent solution shown by the diff. Atomic storage changes prevent partial parent removal. Runtime Host planning resolves child families, rejects busy children, and recovers pre-existing orphans. Desktop classification and locale changes support correct archive presentation. The PR adds archive-plan handling, orphan recovery branches, archive labels, fixture options, and focused regression tests. These additions are necessary for atomicity, recovery, admission protection, and user-visible behavior. No obvious implementation or test code can be removed without weakening coverage. Complexity delta
The total maintenance complexity increases, but the increase is justified by the required atomic behavior and recovery guarantees. Coordination with ValidationCoverage includes:
The final status of required checks is unverified because direct check results were not provided. Review-relevant risks
WalkthroughParent session removal now archives linked subagent sessions instead of leaving them as active top-level tasks. Task settings identifies orphaned subagents with localized deleted-parent text. Storage, runtime, unit, and E2E tests cover the behavior. ChangesParent removal archival
Estimated code review effort: 4 (Complex) | ~45 minutes Merge Risk: ⚪ Minimal · up to The change archives ordinary child sessions when their parent is deleted and preserves them in the archive view; no actionable merge-blocking risk remains after normal checks and review. Sequence Diagram(s)sequenceDiagram
participant User
participant TasksSettingsPage
participant SessionRetirementCoordinator
participant SessionAuthorityStore
participant SqliteSessionMetadataStore
User->>TasksSettingsPage: Delete parent task
TasksSettingsPage->>SessionRetirementCoordinator: Remove parent session
SessionRetirementCoordinator->>SessionAuthorityStore: removeSessionsVersioned(removalSessions, archiveSessions)
SessionAuthorityStore->>SqliteSessionMetadataStore: removeVersioned(removalSessions, archiveSessions)
SqliteSessionMetadataStore-->>SessionAuthorityStore: Commit removal and archival
SessionAuthorityStore-->>SessionRetirementCoordinator: Return retirement result
SessionRetirementCoordinator-->>TasksSettingsPage: Removal completed
TasksSettingsPage-->>User: Show child in archive with deleted-parent label
Possibly related issues
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Pull request overview
Implements “archive ordinary subagent child sessions when their parent is deleted” end-to-end across Storage, Runtime Host retirement, and Desktop archived-task presentation, preventing orphaned subagent tasks from surfacing as top-level active rows after parent deletion.
Changes:
- Extends the SQLite session metadata removal API to support an atomic “remove + archive” commit (with version conflict validation).
- Updates Runtime Host session retirement to derive and admit a stable removal plan that includes direct ordinary subagent child revision families, plus startup recovery reconciliation for pre-existing orphans.
- Enhances Desktop Archived Tasks UI to label orphaned subagent tasks (“Parent task deleted” / “原父任务已删除”), with added unit + E2E coverage.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/storage/src/sqlite-session-metadata-store.ts | Adds atomic archival of additional sessions during versioned removal transactions. |
| packages/storage/src/session-store.ts | Extends store interface and forwards archiveSessions to metadata removal. |
| packages/storage/src/execution-stores.ts | Wires the updated removeSessionsVersioned signature through execution stores. |
| packages/storage/src/tests/sqlite-session-metadata-store.test.ts | Adds coverage for atomic rollback and successful remove+archive behavior. |
| packages/runtime-host/src/server/session-retirement-coordinator.ts | Derives stable removal plan including ordinary subagent children; reconciles orphan archives on recovery. |
| packages/runtime-host/src/tests/session-retirement-coordinator.test.ts | Adds runtime-host tests for child archival, busy-child blocking, and recovery archiving. |
| apps/desktop/src/renderer/settings/tasks-settings-page.tsx | Displays an orphan label in archived task rows when parent is missing. |
| apps/desktop/src/renderer/settings/task-catalog-rows.ts | Adds helper to detect orphaned ordinary subagent tasks. |
| apps/desktop/src/renderer/locales/settings-tasks-copy.ts | Adds localized copy for the “deleted parent” label. |
| apps/desktop/src/main/tests/task-catalog-rows.test.ts | Adds unit test coverage for orphan-label detection logic. |
| apps/desktop/e2e/parent-session-deletion.spec.ts | Adds E2E coverage validating child archival + orphan labeling after parent deletion. |
| apps/desktop/e2e/fixtures.ts | Seeds parent/child sessions for the new E2E scenario. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Thanks for the fix — the core mechanism is solid: the parent-removal + child-archival commit is genuinely atomic (single Conclusion: PASS with two P2s (both need coordination or an explicit deferral note). P2-1 — undeclared coupling with #3074: the P2-2 — a child in the P3 (optional): the busy-error message doesn't say which child is busy (32-child swarm: any one pending interaction blocks the whole delete with AI-assisted review disclosure: this review was produced with AI assistance (two pi review subagents on 中文摘要（AI 辅助审查）结论：PASS（2 个 P2，需协调或显式延后）。核心机制正确：父删除+子归档真原子（单事务 BEGIN IMMEDIATE、版本校验、回滚测试）、busy 门控无竞态（admission lease 覆盖全部计划 id、gate 按 session 串行）、已归档子 Session 真受保护（guard 集跳过 storage、skipNoop 保留时间戳/版本）、启动恢复幂等、subagentParent 唯一关系来源成立；测试真实（原子回滚/32-child swarm/busy-child/恢复/已归档保护）。P2-1：与 #3074 未声明耦合——本 PR 的归档判据依赖 status==='archived' 双写，而 #3074 删除 'archived' 状态、v25 归一化到 active、isArchived 为唯一权威，6 个文件重叠；无论谁先合，另一方的归档保护语义或类型契约会破（若 #3074 先合是类型错误，若本 PR 先合 #3074 迁移会把 status 改写回 active 使 guard 静默失效，违反本 PR 自己"保留归档时间戳/版本"承诺）。建议改为 isArchived-only 判据或显式声明合并顺序。P2-2：preparing 窗口内的 conversation-copy 逃逸归档——删除后 commit 的副本无 subagentParent，恢复逻辑永远看不见它，被 collapseSessionRevisions 选为家族代表后以活跃顶层任务行复活（正是本 PR 声称消除的 fail-open，且持久），无测试覆盖；建议副本路径继承血缘或恢复时把"家族代表已归档但成员活跃"纳入归档触发，至少补测试并记录为已知边界。P3：busy 错误不指明哪个子会话忙（32 子 swarm 一个 pending 交互即阻塞整个删除）、孤儿标签 graph 守卫在桌面是死代码（host 投影不带 graph，新单测覆盖不可达形状）、修订版子 Session 归档页丢孤儿标签（需按家族聚合）、更深层后代不归档（当前产品子会话无法 spawn，可接受）、#withStableRemovalPlan 与 #withStableFamily 机制重复。 |
|
Thanks for the detailed review. I merged the latest What changed:
I intentionally did not add recursive descendant traversal: ordinary linked child Sessions cannot spawn further subagents in the current runtime, so recursion would add an unsupported state model rather than protect a reachable case. I also kept the stable family and stable removal-plan helpers separate because their admitted sets and retry payloads are materially different. Validation completed locally:
CI is running on the new head. 点击展开中文感谢详细审查。已在提交 本次修改：
没有增加递归后代遍历：当前 runtime 不允许普通关联子 Session 再创建 subagent，递归处理的是目前不可到达的状态。也没有合并 stable family 与 stable removal-plan helper，因为两者持有的 admission 集合及重试数据不同，强行抽象反而会降低清晰度并增加并发正确性风险。 本地验证结果：
新 head 的 CI 正在运行。 |
Astro-Han
left a comment
There was a problem hiding this comment.
Thanks for tightening this lifecycle boundary. I reviewed the current head with two independent code-review passes plus a read-only ollama-cloud/deepseek-v4-flash:high pass.
The problem is correctly defined: deleting an ordinary parent must not erase its child transcript, but the child must not remain active or orphaned. This implementation keeps isArchived as the single archive authority, re-resolves the removal plan under admission, and commits child archival plus parent deletion in one SQLite transaction. The already-archived guard and post-commit catalog refresh are necessary concurrency mechanics rather than parallel state.
I found no concrete P0–P2 issue on this head. The remaining opportunities are non-blocking test hardening: inject a storage failure after the child row write to prove rollback, exercise archive-set mutation during plan re-resolution, and pin the direct child-spawn/parent-removal race.
No local test suite was run during this review; conclusions are based on source and test inspection. Codex coordinated the independent passes and performed the final adjudication; the external model output was treated as unverified input until checked against the code.
中文摘要
感谢这次对生命周期边界的收敛。问题定义正确：删除普通父会话时不能删除子会话 transcript，但也不能让子会话继续处于活跃或孤儿状态。
当前实现以 isArchived 作为唯一归档状态，在 admission 下重新解析删除计划，并在同一个 SQLite transaction 中完成子会话归档与父会话删除。已归档 guard 和提交后的 catalog refresh 都是必要的并发机制，不是重复状态。
当前 head 未发现具体的 P0–P2 问题。剩余建议仅是非阻断测试加固：真实存储失败回滚、archive 集合变化、以及直接 child spawn 与 parent removal 的竞态。
本次未在本地运行测试套件；结论来自源码和测试检查。Codex 协调了独立审查并完成最终判断，外部模型输出在核对代码前均视为未验证输入。
Problem
Deleting a parent Session retires its revision family, but leaves ordinary linked subagent Sessions active. Once the parent is gone, the linked-session projection deliberately fails open and promotes those children to top-level rows. Deleting one swarm parent can therefore add up to 32 headless subagent rows to the main task list.
The children cannot be cascade-deleted because each Session owns its own transcript, artifacts, and outputs. Existing orphaned children also need the same treatment as newly created ones.
Solution
subagentParent.parentSessionIdrelation, keeping that relation as the single source of truth.Parent task deleted/原父任务已删除.Parent archival remains unchanged and does not archive ordinary children. Agent Graph operator retirement semantics also remain unchanged.
Validation
Closes #1467
点击展开中文
问题
删除父 Session 时，目前只会清理它的 revision family，普通 subagent Session 仍然保持活跃。父 Session 消失后，关联 Session 的投影逻辑会按照既有的 fail-open 规则，把这些子 Session 提升为顶层任务。因此，删除一个 swarm 父任务后，主任务列表中最多可能突然出现 32 个 headless subagent。
这些子 Session 不能级联删除，因为每个 Session 都拥有独立的对话记录、产物和输出。修改前已经存在的孤儿 Session，也应该与新产生的孤儿得到相同处理。
解决方案
subagentParent.parentSessionId作为唯一关系来源，反向找出父 Session 的直接普通子 Session 及其 revision family。父 Session 的普通归档行为保持不变，不会联动归档普通子 Session；Agent Graph operator 的原有清理语义也保持不变。
验证