fix(cli): declare the transcript viewer's mid-turn disposition - #3485
Closed
Astro-Han wants to merge 1 commit into
Closed
fix(cli): declare the transcript viewer's mid-turn disposition#3485Astro-Han wants to merge 1 commit into
Astro-Han wants to merge 1 commit into
Conversation
`MakaSlashCommand.midTurn` became required so every handler states whether
it is safe to run while a turn is in flight. `/transcript` landed in
parallel and never got an answer, so `main` no longer typechecks:
pi-tui-runner.ts: error TS2741: Property 'midTurn' is missing in type
'{ description: string; run: (parts: string[]) => void; }'
The viewer is a full-screen overlay over the same TUI the running turn
paints into — the picker case `'refuse'` exists for — so that is its
answer.
Generated-by: Claude Code
Astro-Han
marked this pull request as ready for review
August 22, 2026 11:41
Contributor
Author
|
Superseded by #3459, which landed the same declaration on One correction worth recording for anyone who hits this next: the value that landed is Review assisted by AI (Claude Opus 5). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maindoes not typecheck.MakaSlashCommand.midTurnbecame required so every handler has to state whether it is safe to run while a turn is in flight;/transcript(#2999) landed in parallel and never got an answer:Neither PR was wrong on its own — the conflict is semantic, so both merged green and
mainbroke. The viewer is a full-screen overlay over the same TUI the running turn paints into, which is the picker case'refuse'exists for, so that is its declared answer.Refs #2999
Verification
npm run build— passes with this change, fails onmainwithout itnpm run format:check— cleannpm test --workspace maka-agent— 371 pass, 0 failAI use
Select exactly one:
Tool(s) and scope: Claude Code diagnosed the cross-PR type break and wrote the one-line declaration and its comment. The human contributor reviewed the diff and the disposition choice.
Checklist
The compiler is the test:
mainfails to build without this change.Does this PR entail a change in behavior?
/transcriptis now refused mid-turn instead of opening over a running turn.