Skip to content

chore: record the ASF header sweep in .git-blame-ignore-revs - #3501

Merged
jackwener merged 1 commit into
mainfrom
chore/blame-ignore-asf-header-sweep
Aug 22, 2026
Merged

chore: record the ASF header sweep in .git-blame-ignore-revs#3501
jackwener merged 1 commit into
mainfrom
chore/blame-ignore-asf-header-sweep

Conversation

@Astro-Han

Copy link
Copy Markdown
Contributor

Summary

.git-blame-ignore-revs documents its own convention: a reformat PR adds its landed hash here in a follow-up right after the squash, because an entry naming a hash the clone has never seen makes git blame error out with cannot find revision ... to ignore rather than degrading. #3397 left the placeholder in place, as its commit message said it would. This fills it in with c633ea5b2524d9463228e01f8d369ef9166c3f05, the squash commit that landed on main.

Without the entry, all 2679 files the header sweep touched blame to that commit, even though it changed no line of their content.

Refs #3397

Verification

  • c633ea5b2524d9463228e01f8d369ef9166c3f05 confirmed present on main (git log -1 resolves it), which is the precondition the file itself states.
  • node scripts/asf-license-headers.mjs check on this branch: 2681 covered, 114 excluded, clean. Unrelated to this change, but it is the gate chore: add ASF source headers and a release header audit gate #3397 introduced and this branch is the first thing on top of it.
  • No test covers this: the file is consumed by git blame and by GitHub's blame view, not by anything in the build. Nothing to run beyond confirming the hash resolves.

Review focus

One thing worth a maintainer's call, not addressed here: the # style: apply Biome format baseline outside the UI surface (#415) entry above still carries its own unfilled placeholder, so that sweep is not actually being ignored either. Filling it needs the landed hash for #415, which is a separate lookup and a separate intent — happy to do it in another PR if you want it.

AI use

Select exactly one:

  • No generative tool made a substantive contribution
  • Generative tooling made a substantive contribution

Tool(s) and scope: Claude Code — wrote the change and this description. The commit carries a Generated-by: Claude Code trailer.

Checklist

  • Tests cover the change and fail without it
  • Lint, format, typecheck and the affected suites pass locally

Does this PR entail a change in behavior?

  • Yes — described under Summary above
  • No

`.git-blame-ignore-revs` documents that a reformat PR adds its landed hash
here in a follow-up right after the squash, because an entry that names a
hash the clone has never seen makes `git blame` error out instead of
degrading. #3397 left the placeholder; this fills it in with the squash
commit that landed on main.

The sweep touched 2679 files without changing a line of their content, so
without this entry every one of them blames to that commit.

Generated-by: Claude Code

@jackwener jackwener left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Authorized by @WAWQAQ in Raft task #11 after independent review at exact head d3cf64b. The referenced #3397 squash exists on main, the ignore-revs entry is correctly scoped, and required test is terminal green.

@jackwener jackwener left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on exact head d3cf64b67bd4531586bbc31a04ecdb9247ebaae1.

The filled hash c633ea5b2524d9463228e01f8d369ef9166c3f05 is the #3397 squash on main. One-file follow-up matches .git-blame-ignore-revs convention.

Authorization: @WAWQAQ in Raft #PR-Review-Kabi:778d6db7.

@jackwener
jackwener merged commit 3bb0146 into main Aug 22, 2026
1 check passed
@jackwener
jackwener deleted the chore/blame-ignore-asf-header-sweep branch August 22, 2026 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants