chore: record the ASF header sweep in .git-blame-ignore-revs - #3501
Merged
Conversation
`.git-blame-ignore-revs` documents that a reformat PR adds its landed hash here in a follow-up right after the squash, because an entry that names a hash the clone has never seen makes `git blame` error out instead of degrading. #3397 left the placeholder; this fills it in with the squash commit that landed on main. The sweep touched 2679 files without changing a line of their content, so without this entry every one of them blames to that commit. Generated-by: Claude Code
jackwener
approved these changes
Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.git-blame-ignore-revsdocuments its own convention: a reformat PR adds its landed hash here in a follow-up right after the squash, because an entry naming a hash the clone has never seen makesgit blameerror out withcannot find revision ... to ignorerather than degrading. #3397 left the placeholder in place, as its commit message said it would. This fills it in withc633ea5b2524d9463228e01f8d369ef9166c3f05, the squash commit that landed onmain.Without the entry, all 2679 files the header sweep touched blame to that commit, even though it changed no line of their content.
Refs #3397
Verification
c633ea5b2524d9463228e01f8d369ef9166c3f05confirmed present onmain(git log -1resolves it), which is the precondition the file itself states.node scripts/asf-license-headers.mjs checkon this branch: 2681 covered, 114 excluded, clean. Unrelated to this change, but it is the gate chore: add ASF source headers and a release header audit gate #3397 introduced and this branch is the first thing on top of it.git blameand by GitHub's blame view, not by anything in the build. Nothing to run beyond confirming the hash resolves.Review focus
One thing worth a maintainer's call, not addressed here: the
# style: apply Biome format baseline outside the UI surface (#415)entry above still carries its own unfilled placeholder, so that sweep is not actually being ignored either. Filling it needs the landed hash for #415, which is a separate lookup and a separate intent — happy to do it in another PR if you want it.AI use
Select exactly one:
Tool(s) and scope: Claude Code — wrote the change and this description. The commit carries a
Generated-by: Claude Codetrailer.Checklist
Does this PR entail a change in behavior?