PR-QODERWORK-GLASS-RESHIP-L3-L6-L7: re-ship 3 layers that never landed - #375
Merged
Merged
Conversation
…anded The original PR-QODERWORK-GLASS-LAYERED-0 push tried to ship 5 layers (L1+L2+L3+L6+L7) but only L1 (vibrancy unblock) actually landed on main via the squash-merge of PR #329 (`7d008d51`). The follow-up commit `023b90b2` was force-pushed to the same branch but the merge happened before that, so for the past 3 days users have been seeing the QoderWork "classic" look despite the substrate being correctly enabled. This re-ships L3 + L6 + L7 from that delta: **L6 — warm token vocabulary** New CSS custom props on `html[data-os="darwin"]`: `--color-bg-layout #fdfcfa`, `-highlight #c9c4b8`, `-container #faf9f6`, `-element #f5f3ee`, `-state-selected #8ee5a1`, `-text-quaternary 45%-fg`. Notable rename per @maka-审美专家 token-naming critic: was going to be `--color-row-selected` / `--color-primary`, now `--color-state-selected` so it's reusable for chip / tab / nav selected states without renaming later. **L3 — selected vs hover finally distinguishable** Active `.maka-list-row[data-active="true"]` paints `var(--color-state- selected)` (mint `#8ee5a1`) instead of the 6% foreground wash that was identical to `:hover`. Font-weight stays 500 — the color block IS the signal. Active session reads at a glance instead of "where's the cursor again". Same root cause as punch-list-polish-2 #S2 (hover/selected indistinguishable) which has been stuck for 3 days because L3 never shipped. **L7 — un-stylize group label** `.maka-list-group-label` was 9.5px UPPERCASE + 0.08em tracking on the sidebar; reads as "Windows admin tool" not "macOS native sidebar". QoderWork uses plain quaternary text at body size. Drop the size / transform / tracking on macOS; the natural color step is enough. NOT in this PR: - **L2 (blur 8px → 24px)** — needs real-window verification of the blur strength before pinning a number - **L1 (move blur from .maka-session-panel to .agents-layout-root)** — needs coordinated move of the existing 8px rule, separate concern from this "re-ship what was missing" PR All gated on `[data-os="darwin"]` so non-macOS keeps existing chrome. Pure-CSS, no JSX surgery. Tests: `tsc --noEmit` clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
@maka-审美专家 just realized (and verified with git log) that the original PR-QODERWORK-GLASS-LAYERED-0 push only landed L1 on
main. The squash-merge of PR #329 (7d008d51) captured the vibrancy-unblock commit but the follow-up commit023b90b2containing L3/L6/L7 was force-pushed to the same branch AFTER the merge had already happened.For the past 3 days users have been seeing the QoderWork "classic" look despite the substrate being correctly enabled. The "hover and selected look identical" complaint that's been on
punch-list-polish-2 #S2is the same root cause — L3 never shipped.This PR re-ships L3 + L6 + L7. L1 and L2 are deferred (see below).
What's in this PR
L6 — warm token vocabulary
New CSS custom props on
html[data-os="darwin"], extracted from/tmp/qoder-asar/out/renderer/reference bundle:Notable rename per @maka-审美专家 critic: was originally going to be
--color-row-selected/--color-primary; now--color-state-selectedso it's reusable for chip / tab / nav selected states later without renaming.L3 — selected vs hover finally distinguishable
Active
.maka-list-row[data-active="true"]paintsvar(--color-state-selected)(mint#8ee5a1) instead of the 6% foreground wash that was identical to:hover. Font-weight stays 500 — the color block IS the signal, not the weight stacking.L7 — un-stylize group label
.maka-list-group-labelwas 9.5px UPPERCASE + 0.08em tracking on the sidebar (reads as "old Windows admin tool"). QoderWork uses plain quaternary text at body size. Drops the size / transform / tracking on macOS; natural color step from--color-text-quaternaryis enough hierarchy.What's NOT in this PR
.maka-session-panelto.agents-layout-root) — needs coordinated move of the existing 8px rule; separate concern from "re-ship what was missing"--primarytoken. Documented in PR-MODEL-ROW-AND-OAUTH-EMAIL-FIX-0: 2 of 6 bug bundle (height-clip + email-leak) #373 alreadyScope discipline
[data-os="darwin"]; non-macOS unaffectedtsc --noEmitclean (pre-existing main.ts:888 + model-catalog-choices.test.ts errors are unrelated)