Skip to content

PR-QODERWORK-GLASS-RESHIP-L3-L6-L7: re-ship 3 layers that never landed - #375

Merged
jackwener merged 1 commit into
mainfrom
yuejing/qoderwork-glass-reship-l3-l6-l7
Jun 30, 2026
Merged

PR-QODERWORK-GLASS-RESHIP-L3-L6-L7: re-ship 3 layers that never landed#375
jackwener merged 1 commit into
mainfrom
yuejing/qoderwork-glass-reship-l3-l6-l7

Conversation

@jackwener

Copy link
Copy Markdown
Member

Why

@maka-审美专家 just realized (and verified with git log) that the original PR-QODERWORK-GLASS-LAYERED-0 push only landed L1 on main. The squash-merge of PR #329 (7d008d51) captured the vibrancy-unblock commit but the follow-up commit 023b90b2 containing L3/L6/L7 was force-pushed to the same branch AFTER the merge had already happened.

For the past 3 days users have been seeing the QoderWork "classic" look despite the substrate being correctly enabled. The "hover and selected look identical" complaint that's been on punch-list-polish-2 #S2 is the same root cause — L3 never shipped.

This PR re-ships L3 + L6 + L7. L1 and L2 are deferred (see below).

What's in this PR

L6 — warm token vocabulary

New CSS custom props on html[data-os="darwin"], extracted from /tmp/qoder-asar/out/renderer/ reference bundle:

--color-bg-layout: #fdfcfa;
--color-bg-highlight: #c9c4b8;
--color-bg-container: #faf9f6;
--color-bg-element: #f5f3ee;
--color-state-selected: #8ee5a1;
--color-text-quaternary: oklch(from var(--foreground) l c h / 0.45);

Notable rename per @maka-审美专家 critic: was originally going to be --color-row-selected / --color-primary; now --color-state-selected so it's reusable for chip / tab / nav selected states later without renaming.

L3 — selected vs hover finally distinguishable

Active .maka-list-row[data-active="true"] paints var(--color-state-selected) (mint #8ee5a1) instead of the 6% foreground wash that was identical to :hover. Font-weight stays 500 — the color block IS the signal, not the weight stacking.

L7 — un-stylize group label

.maka-list-group-label was 9.5px UPPERCASE + 0.08em tracking on the sidebar (reads as "old Windows admin tool"). QoderWork uses plain quaternary text at body size. Drops the size / transform / tracking on macOS; natural color step from --color-text-quaternary is enough hierarchy.

What's NOT in this PR

Scope discipline

  • All gated on [data-os="darwin"]; non-macOS unaffected
  • Pure-CSS, no JSX surgery
  • tsc --noEmit clean (pre-existing main.ts:888 + model-catalog-choices.test.ts errors are unrelated)

…anded

The original PR-QODERWORK-GLASS-LAYERED-0 push tried to ship 5 layers
(L1+L2+L3+L6+L7) but only L1 (vibrancy unblock) actually landed on main
via the squash-merge of PR #329 (`7d008d51`). The follow-up commit
`023b90b2` was force-pushed to the same branch but the merge happened
before that, so for the past 3 days users have been seeing the
QoderWork "classic" look despite the substrate being correctly enabled.

This re-ships L3 + L6 + L7 from that delta:

**L6 — warm token vocabulary**
New CSS custom props on `html[data-os="darwin"]`: `--color-bg-layout
#fdfcfa`, `-highlight #c9c4b8`, `-container #faf9f6`, `-element
#f5f3ee`, `-state-selected #8ee5a1`, `-text-quaternary 45%-fg`. Notable
rename per @maka-审美专家 token-naming critic: was going to be
`--color-row-selected` / `--color-primary`, now `--color-state-selected`
so it's reusable for chip / tab / nav selected states without renaming
later.

**L3 — selected vs hover finally distinguishable**
Active `.maka-list-row[data-active="true"]` paints `var(--color-state-
selected)` (mint `#8ee5a1`) instead of the 6% foreground wash that was
identical to `:hover`. Font-weight stays 500 — the color block IS the
signal. Active session reads at a glance instead of "where's the cursor
again". Same root cause as punch-list-polish-2 #S2 (hover/selected
indistinguishable) which has been stuck for 3 days because L3 never
shipped.

**L7 — un-stylize group label**
`.maka-list-group-label` was 9.5px UPPERCASE + 0.08em tracking on the
sidebar; reads as "Windows admin tool" not "macOS native sidebar".
QoderWork uses plain quaternary text at body size. Drop the size /
transform / tracking on macOS; the natural color step is enough.

NOT in this PR:

- **L2 (blur 8px → 24px)** — needs real-window verification of the blur
  strength before pinning a number
- **L1 (move blur from .maka-session-panel to .agents-layout-root)** —
  needs coordinated move of the existing 8px rule, separate concern
  from this "re-ship what was missing" PR

All gated on `[data-os="darwin"]` so non-macOS keeps existing chrome.
Pure-CSS, no JSX surgery. Tests: `tsc --noEmit` clean.
@jackwener
jackwener merged commit 6e97fc1 into main Jun 30, 2026
@Astro-Han
Astro-Han deleted the yuejing/qoderwork-glass-reship-l3-l6-l7 branch July 14, 2026 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant