fix(desktop): purge engineering-speak from user-facing copy (detail round 5) - #648
Merged
Conversation
…ound 5)
- Lineage badges no longer expose raw internal turn IDs ("重新生成自
turn regen-" truncated mid-slug). Labels now state the action:
"重新生成自旧回答" / "已重新生成 → 新回答"; tooltips explain the
click target. Dead shortId() helper removed.
- 默认模型 helper text dropped the implementation clause ("按连接分组，
不显示 OAuth 账号邮箱") — describes grouping internals, not the setting.
- 关于 page workspace path row gained the mono treatment the 数据 page
already uses (left-aligned mono caption instead of right-aligned
ragged proportional wrap).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detail-audit round 5, continuing the systematic copy/affordance sweep — this round targets engineering-speak leaking into user-facing copy, found while reviewing the post-#636 streaming UI.
Findings & fixes
1. Lineage badges exposed raw internal turn IDs
deriveTurnLineageBadgesrendered重新生成自 turn ${shortId(id)}— a 6-char slice of the internal turn ID. Users can't correlate these IDs with anything on screen (they appear nowhere else), and the hardslice(0, 6)truncates mid-word with no ellipsis (fixture showed "turn regen-"). The pill is a jump button; its label should state the action, not an internal pointer:重新生成自旧回答(tooltip: 点击查看被保留的旧回答)已重新生成 → 新回答(tooltip: 点击跳转到重新生成的新回答)Dead
shortId()removed. Contract tests only pin the 重新生成自/已重新生成 vocabulary prefixes (#546 retry→regenerate merge) — unchanged.2. 默认模型 helper text described implementation, not the setting
"新对话默认使用的具体模型；按连接分组，不显示 OAuth 账号邮箱。" — the second clause narrates picker internals (grouping + privacy of the dropdown). Now: "新对话默认使用的模型。"
3. 关于 page workspace path missed the mono treatment
The 数据 page renders paths left-aligned mono caption (
SettingRow mono); the 关于 page's 工作区 row rendered the same path right-aligned proportional, wrapping into a ragged multi-line block. Addedmono.Verification
turn-control-historyfixture confirms clean pill labels (screenshot-verified)check-dead-cssclean