fix: preserve Ollama Cloud aliases without auth - #907
Merged
Conversation
This was referenced Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
:cloudaliases across local-daemon discovery, persisted model state, Desktop selection, Headless host-cell routing, and both turns of an agent tool-call loop.qwen3.5:cloudcontract.Authorization: Bearer ollamaheader into no-auth local daemon requests.Why
Refs #860.
Ollama Cloud models run through the existing signed-in local Ollama daemon and retain the existing persisted
ollamaprovider ID. Ollama's local API requires no request authentication; the daemon owns its ollama.com sign-in state. The previous OpenAI-compatible adapter fallback injected a dummy bearer value even thoughollamais registry-declared no-auth. Removing that single-purpose fallback restores the no-auth invariant without adding a Cloud provider, key, endpoint, or parallel runtime path.Scope
ProviderLogopath, and the existing provenance/notice contract remains green.Verification
npm run typecheck— passed for every workspace.npm --workspace @maka/core test— passed.npm --workspace @maka/storage test— passed; includes exact local/Cloud discovery snapshot and selected-default persistence.npm --workspace @maka/runtime test— passed; includes separate complex local-ID andqwen3.5:clouddiscovery/two-stage tool-call cases, with no Authorization header on discovery or chat.npm --workspace @maka/headless test— passed; includes separate complex local-ID andqwen3.5:cloudno-auth host-cell cases.npm --workspace @maka/desktop test— passed; includes exact local/Cloud catalog distinction and unchanged Cloud selection, plus the existing Ollama SVG/provenance/notice/shared-render-path contract.npm run check:stale— passed.git diff --check origin/main...HEAD— passed.Impact
Existing Ollama connections keep the same provider ID, local daemon endpoint, model discovery, selection, and runtime path. Exact local and Cloud model IDs remain unchanged. Local daemon requests no longer carry a dummy Authorization header. No migration, documentation, release-note, or user-visible UI change is required.
Reviewer notes
Please focus on the local-daemon ownership boundary: Maka supplies no Cloud key or hosted endpoint, while a signed-in Ollama daemon handles Cloud access. The runtime fixture deliberately distinguishes
qwen3.5fromqwen3.5:cloud, and the pre-existinghf.co/bartowski/Qwen2.5-Coder-7B-Instruct-GGUF:Q4_K_Mcase remains independently covered.Official contract references:
Ready for review
Verificationexplains why it is not applicable