fix(cu): fence failed host reads after stop - #928
Merged
Conversation
Contributor
Author
|
@Astro-Han Follow-up to the remaining merged #921 P2 is isolated and CI is fully green. Failed cursor_position/wait results that complete after clearSession are now discarded as user_stopped; the action-only outcome_unknown exception remains intact. Ready for review. |
Astro-Han
approved these changes
Jul 14, 2026
Astro-Han
left a comment
Contributor
There was a problem hiding this comment.
No P0/P1 findings. One non-blocking issue remains:
- P2: A normal
cursor_positionorwaitfailure such asservice_unavailableis converted toreobserve_required.applyTypedOutcomeState()changes the generation before the new observation-lease validation runs, so the original typed error is lost even when no stop occurred.
Checking the pre-existing lease before applying the returned outcome state would preserve both behaviors: late results after clearSession() remain user_stopped, while ordinary backend failures retain their typed error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the remaining P2 on merged #921.
cursor_positionandwaitregardless of backend success or failureservice_unavailableresults afterclearSession()outcome_unknownexception from fix(cu): preserve unknown dispatch outcomes #921Verification
git diff --check