Skip to content

fix(cu): fence failed host reads after stop - #928

Merged
Astro-Han merged 1 commit into
apache:mainfrom
hqhq1025:codex/cu-host-read-fence
Jul 14, 2026
Merged

fix(cu): fence failed host reads after stop#928
Astro-Han merged 1 commit into
apache:mainfrom
hqhq1025:codex/cu-host-read-fence

Conversation

@hqhq1025

Copy link
Copy Markdown
Contributor

Summary

Follow-up to the remaining P2 on merged #921.

  • revalidate observation leases after cursor_position and wait regardless of backend success or failure
  • discard late service_unavailable results after clearSession()
  • preserve the action-only outcome_unknown exception from fix(cu): preserve unknown dispatch outcomes #921

Verification

  • Runtime typecheck
  • focused Computer Use/session-state suite
  • regression coverage for failed cursor and wait calls completing after stop
  • git diff --check

@hqhq1025

Copy link
Copy Markdown
Contributor Author

@Astro-Han Follow-up to the remaining merged #921 P2 is isolated and CI is fully green. Failed cursor_position/wait results that complete after clearSession are now discarded as user_stopped; the action-only outcome_unknown exception remains intact. Ready for review.

@Astro-Han Astro-Han left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No P0/P1 findings. One non-blocking issue remains:

  • P2: A normal cursor_position or wait failure such as service_unavailable is converted to reobserve_required. applyTypedOutcomeState() changes the generation before the new observation-lease validation runs, so the original typed error is lost even when no stop occurred.

Checking the pre-existing lease before applying the returned outcome state would preserve both behaviors: late results after clearSession() remain user_stopped, while ordinary backend failures retain their typed error.

@Astro-Han
Astro-Han merged commit a4a0cc8 into apache:main Jul 14, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants