Skip to content

feat: add AskUserQuestion desktop flow - #939

Merged
Astro-Han merged 7 commits into
mainfrom
feat/825-ask-user-question-desktop
Jul 14, 2026
Merged

feat: add AskUserQuestion desktop flow#939
Astro-Han merged 7 commits into
mainfrom
feat/825-ask-user-question-desktop

Conversation

@Astro-Han

Copy link
Copy Markdown
Contributor

Summary

  • register PR2's AskUserQuestion tool only for the Desktop root agent
  • add the validated main/preload/renderer response route
  • replace the permission-only queue with one per-session FIFO shared by permissions and questions
  • render one question at a time in the existing composer takeover, including descriptions, client-owned Other, Previous/Next, nullable answers, Stop, and one final submit
  • cover the complete fake-backend same-turn continuation plus focused IPC, renderer, style, and keyboard-focus contracts

Scope

Desktop root-agent registration and UI only. This does not add the tool to headless/Harbor, Pi transport, or child agents, and it reuses the runtime protocol merged in PR #908.

Part of #825.

Screenshot

AskUserQuestion Desktop production Storybook

The screenshot is captured from the production UserQuestionPrompt Storybook story at 1280×720.

Verification

  • npm run typecheck
  • npm --workspace @maka/ui test — 134 passed
  • npm --workspace @maka/runtime test — passed
  • npm --workspace @maka/desktop test — 2474 passed
  • npm --workspace @maka/desktop run e2e -- ask-user-question.spec.ts — 1 passed
  • full Desktop Electron E2E suite — 27 passed during implementation
  • check-console, check-a11y, and check-copy — passed

Review

Independent reviewer verdict: GO. The final implementation keeps one runtime protocol and one interaction queue; no P0–P3 findings remain after the keyboard-focus and screenshot-label fixes.

@Astro-Han
Astro-Han merged commit 674ee6c into main Jul 14, 2026
3 checks passed
@Astro-Han
Astro-Han deleted the feat/825-ask-user-question-desktop branch July 14, 2026 00:45
Astro-Han added a commit that referenced this pull request Jul 16, 2026
docs/screenshots/ holds issue-878 and AskUserQuestion evidence images
(#901, #939). No tracked file references them, and the PR bodies embed
them via raw URLs pinned to PR-branch SHAs, which GitHub keeps serving
(verified HTTP 200) independently of main.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant