feat: add AskUserQuestion desktop flow - #939
Merged
Merged
Conversation
This was referenced Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AskUserQuestiontool only for the Desktop root agentScope
Desktop root-agent registration and UI only. This does not add the tool to headless/Harbor, Pi transport, or child agents, and it reuses the runtime protocol merged in PR #908.
Part of #825.
Screenshot
The screenshot is captured from the production
UserQuestionPromptStorybook story at 1280×720.Verification
npm run typechecknpm --workspace @maka/ui test— 134 passednpm --workspace @maka/runtime test— passednpm --workspace @maka/desktop test— 2474 passednpm --workspace @maka/desktop run e2e -- ask-user-question.spec.ts— 1 passedcheck-console,check-a11y, andcheck-copy— passedReview
Independent reviewer verdict: GO. The final implementation keeps one runtime protocol and one interaction queue; no P0–P3 findings remain after the keyboard-focus and screenshot-label fixes.