Skip to content
This repository was archived by the owner on Nov 17, 2023. It is now read-only.

Re-enabling randomized test_operator/test_operator_gpu.test_dot #11888

Merged
marcoabreu merged 1 commit into from
Jul 25, 2018
Merged

Re-enabling randomized test_operator/test_operator_gpu.test_dot #11888

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions tests/python/unittest/test_operator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2506,8 +2506,9 @@ def test_stn_valid_sampling():
) + target_shape))


# Seed set because the test is not robust enough to operate on random data
@with_seed(1234)
# @haojin2: Getting rid of fixed seed as flakiness could not be reproduced,
# tracked at https://github.com/apache/incubator-mxnet/issues/11714

@marcoabreu marcoabreu Jul 25, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to remove that comment

@haojin2 haojin2 Jul 25, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's still keep it here, in case if it fails on some other platforms, or we detect any regression on this operator in the future. What do you think?

@marcoabreu marcoabreu Jul 25, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me

@with_seed()
def test_dot():
ctx=default_context()
dtypes = ['float32', 'float64']
Expand Down