Use javac release option where possible - #7247
Merged
Merged
Conversation
This was referenced Apr 5, 2024
doesn't include modules which use nb-javac
mbien
force-pushed
the
use-release-flag
branch
2 times, most recently
from
May 20, 2024 05:19
cabf9a9 to
2b114b3
Compare
mbien
marked this pull request as ready for review
May 20, 2024 05:22
Member
Author
|
Opening this branch in NB 22 rc4 shows no error markers, so it seems to be working. |
Member
Author
|
we can probably merge this now since devs are now able to switch to the NB22 release while working on netbeans |
matthiasblaesing
approved these changes
May 24, 2024
matthiasblaesing
left a comment
Contributor
There was a problem hiding this comment.
Looks sane to me. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part 2 of #7188, this is for NB 23
changes here are only for modules which don't use nb-javac, but if #7201 is merged this could update more.