Fix Javadoc external link errors - #8625
Merged
neilcsmith-net merged 3 commits intoJul 10, 2025
Merged
Conversation
neilcsmith-net
marked this pull request as draft
June 26, 2025 09:51
neilcsmith-net
marked this pull request as ready for review
June 26, 2025 11:34
ebarboni
approved these changes
Jun 26, 2025
ebarboni
left a comment
Contributor
There was a problem hiding this comment.
LGTM according to the filechange, checks are bugged on my ui
mbien
reviewed
Jun 26, 2025
neilcsmith-net
marked this pull request as draft
July 9, 2025 14:57
neilcsmith-net
force-pushed
the
javadoc-external-links
branch
from
July 9, 2025 16:18
28873dd to
f5ba89e
Compare
neilcsmith-net
force-pushed
the
javadoc-external-links
branch
from
July 9, 2025 17:00
f5ba89e to
f909ca3
Compare
neilcsmith-net
marked this pull request as ready for review
July 10, 2025 08:42
Member
Author
|
OK, cherry picked the original fixes on top. Let's check these now pass. Thanks @mbien |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jenkins build currently reporting a disallowed external link in Javadoc due to link to https://services.gradle.org/versions/current in #8606
This is not picked up in the GitHub build - add report to output before fixing.
Fix to allow all links to services.gradle.org - good possibility we'll want to link to other things on there in future.
Also fixes incorrect and invalid JNA link and information in Javadoc I noticed while addressing this.