Add excludeRowIds to search method#58
Draft
steFaiz wants to merge 4 commits into
Draft
Conversation
Author
|
@JingsongLi PTAL if you have some time, thanks! |
Author
|
I think this may be not necessary. For RBM, storing includeRowIds as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Parts of apache/paimon#8322
This PR add an
excludeRowIdsparam to vector search, so that those deleted vectors will not affect choosing real-top-K similar vectors.Core changes:
RowIdFilterstruct to a new common file. Re export this class inivfpqfile to ensure backward compatibilityTests
Add tests for core, c, c++, java, python module