[parquet] Fix that parquet filter pushdown wrong for decimal#8623
Open
yuzelin wants to merge 2 commits into
Open
[parquet] Fix that parquet filter pushdown wrong for decimal#8623yuzelin wants to merge 2 commits into
yuzelin wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix problem of #7175.
Fix incorrect Parquet dictionary filtering for high-precision decimals.
Decimal literals for FIXED_LEN_BYTE_ARRAY columns are now sign-extended to the physical Parquet width, matching the writer encoding. This prevents valid row groups from being incorrectly pruned when the literal and dictionary value represent the same number with different byte lengths.
Added regression tests for positive, negative, IN, and dictionary-filter cases.
Tests