[python][ray] Fix zero-block overwrite#8632
Open
QuakeWang wants to merge 1 commit into
Open
Conversation
Ray 2.53+ defers Datasink.on_write_start until the first input bundle. A zero-block dataset still reaches PaimonDatasink.on_write_complete without initializing the driver-side writer builder. Whole-table and static-partition overwrites then fail before commit([]). Initialize the writer builder on demand only when completion needs to commit. Cover the skipped callback and zero-block overwrite paths. Signed-off-by: QuakeWang <wangfuzheng0814@foxmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Ray 2.53+ defers
Datasink.on_write_start()until the first input bundle. A zero-block dataset has no bundle, buton_write_complete()still runs, leaving Paimon's writer builder uninitialized. Whole-table and static-partition overwrites therefore fail beforecommit([]).Initialize the writer builder on demand when completion needs to commit. Zero-block append writes remain no-ops.
Tests
on_write_start()callback.ray.data.range(0).RaySinkTestandRayIntegrationTeston Ray 2.54.0.