Skip to content

[cleanup] reference to C++ and Python client - #17919

Merged
merlimat merged 3 commits into
apache:masterfrom
tisonkun:cleanup-reference-to-client-cpp
Oct 5, 2022
Merged

merlimat merged 3 commits into
apache:masterfrom
tisonkun:cleanup-reference-to-client-cpp

Conversation

@tisonkun

@tisonkun tisonkun commented Oct 4, 2022 •

Copy link
Copy Markdown
Member

This closes #17916.

Documentation

  • doc-required
  • doc-not-needed
  • doc
  • doc-complete

Matching PR in forked repository

PR in forked repository: tisonkun#4

Signed-off-by: tison <wander4096@gmail.com>
@github-actions github-actions Bot added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Oct 4, 2022
@tisonkun

tisonkun commented Oct 4, 2022

Copy link
Copy Markdown
Member Author

@tisonkun

tisonkun commented Oct 4, 2022

Copy link
Copy Markdown
Member Author

/pulsarbot run-failure-checks

Comment thread pom.xml Outdated
Comment thread pom.xml Outdated
Comment thread pom.xml Outdated
@tisonkun

tisonkun commented Oct 4, 2022

Copy link
Copy Markdown
Member Author

@merlimat thank you! Comments addressed.

@tisonkun
tisonkun requested review from merlimat and removed request for nicoloboschi October 4, 2022 23:31
@tisonkun

tisonkun commented Oct 5, 2022

Copy link
Copy Markdown
Member Author

/pulsarbot run-failure-checks

@tisonkun

tisonkun commented Oct 5, 2022

Copy link
Copy Markdown
Member Author

@merlimat @BewareMyPower CI failed on #17921

I don't know whether it's related to this patch: I can pass the test locally, and it seems logically unrelated. But also I don't ever see it before. Perhaps rerun once more to see.

@tisonkun

tisonkun commented Oct 5, 2022

Copy link
Copy Markdown
Member Author

/pulsarbot run-failure-checks

@tisonkun

tisonkun commented Oct 5, 2022

Copy link
Copy Markdown
Member Author

It seems rerun does not work.

ping @merlimat @lhotari @BewareMyPower

@BewareMyPower

BewareMyPower commented Oct 5, 2022 •

Copy link
Copy Markdown
Contributor

@tisonkun The tests (of 4742b6f) passed in my local env, I'll rerun again.

@merlimat
merlimat merged commit 1234698 into apache:master Oct 5, 2022
@tisonkun
tisonkun deleted the cleanup-reference-to-client-cpp branch October 9, 2022 07:37
@Anonymitaet

Copy link
Copy Markdown
Member

@tisonkun thank you! I've updated other related occurrences apache/pulsar-site#245

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. ready-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cleanup or migrate all reference to pulsar-client-cpp and the python client

5 participants