Repository navigation
Support topicl level offload - #7883
Merged
Merged
Conversation
codelipenghui
left a comment
Contributor
There was a problem hiding this comment.
Looks good, could you please also update the CmdTopics in the pulsar-client-tools ?
Contributor
Author
This has been solved |
# Conflicts: # pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/Topics.java # pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdTopics.java # pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/TopicPolicies.java
Contributor
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Sep 1, 2020
Contributor
Author
|
/pulsarbot run-failure-checks |
1 similar comment
Contributor
Author
|
/pulsarbot run-failure-checks |
Contributor
Author
|
/pulsarbot run-failure-checks |
Contributor
Author
|
/pulsarbot run-failure-checks |
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
### Motivation Support set Offload Policy on topic level ### Modifications Support set/get/remove Offload policy on topic level. ### Verifying this change Added Unit test to verify set/get/remove Offload policy at Topic level work as expected when Topic level policy is enabled/disabled `org.apache.pulsar.broker.admin.AdminApiOffloadTest#testOffloadPoliciesApi` `org.apache.pulsar.broker.admin.AdminApiOffloadTest#testTopicLevelOffload`
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
### Motivation Support set Offload Policy on topic level ### Modifications Support set/get/remove Offload policy on topic level. ### Verifying this change Added Unit test to verify set/get/remove Offload policy at Topic level work as expected when Topic level policy is enabled/disabled `org.apache.pulsar.broker.admin.AdminApiOffloadTest#testOffloadPoliciesApi` `org.apache.pulsar.broker.admin.AdminApiOffloadTest#testTopicLevelOffload`
lbenc135
pushed a commit
to lbenc135/pulsar
that referenced
this pull request
Sep 5, 2020
### Motivation Support set Offload Policy on topic level ### Modifications Support set/get/remove Offload policy on topic level. ### Verifying this change Added Unit test to verify set/get/remove Offload policy at Topic level work as expected when Topic level policy is enabled/disabled `org.apache.pulsar.broker.admin.AdminApiOffloadTest#testOffloadPoliciesApi` `org.apache.pulsar.broker.admin.AdminApiOffloadTest#testTopicLevelOffload`
1 task done
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Support set Offload Policy on topic level
Modifications
Support set/get/remove Offload policy on topic level.
Verifying this change
Added Unit test to verify set/get/remove Offload policy at Topic level work as expected when Topic level policy is enabled/disabled
org.apache.pulsar.broker.admin.AdminApiOffloadTest#testOffloadPoliciesApiorg.apache.pulsar.broker.admin.AdminApiOffloadTest#testTopicLevelOffload