TIKA-4831: The icon of a GeoGebra tool is its thumbnail

[dschmidt]

Follow-up to #3044: a tool file (.ggt) has no geogebra_thumbnail.png, but a tool can have an icon, stored in a directory with a generated name and referenced by the macro's iconFile attribute (File Format reference, ".ggt"). The parser now emits that icon as the tool's THUMBNAIL, and not a second time as a picture.

Order of preference is unchanged for the other files: the worksheet thumbnail, then the first slide thumbnail, then the tool icon. A worksheet with an embedded tool keeps its own thumbnail; the icon stays INLINE there.

I could not find a real .ggt with an icon anywhere public (GitHub does not index binaries, GeoGebra's site offers no tools for download), so the test builds one after the XML reference.

https://issues.apache.org/jira/browse/TIKA-4831

[Copilot]

Pull request overview

This PR updates the GeoGebra parsing logic so that a GeoGebra tool’s icon (referenced via the macro’s iconFile inside a .ggt) is treated as the document thumbnail (embeddedResourceType=THUMBNAIL) and is not emitted again as a normal picture, aligning Tika output with how GeoGebra represents tools.

Changes:

• Collect iconFile values from macros while parsing geogebra_macro.xml.
• Extend thumbnail selection to fall back to the first existing tool icon when no worksheet/slide thumbnail is available, and avoid duplicate emission of that same entry.
• Add unit tests that synthesize a .ggt/worksheet-with-macro to verify THUMBNAIL vs INLINE behavior, and document the change in CHANGES.txt.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-miscoffice-module/src/test/java/org/apache/tika/parser/geogebra/GeoGebraParserTest.java	Adds tests covering tool-icon-as-thumbnail and worksheet-thumbnail precedence over embedded tool icon.
tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-miscoffice-module/src/main/java/org/apache/tika/parser/geogebra/GeoGebraXMLHandler.java	Records macro iconFile paths during SAX parsing for later thumbnail selection.
tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-miscoffice-module/src/main/java/org/apache/tika/parser/geogebra/GeoGebraParser.java	Updates thumbnail selection order to include tool icons and prevents double-emitting the chosen thumbnail entry.
CHANGES.txt	Notes the GeoGebra tool icon THUMBNAIL behavior change for the upcoming release.

Suppressed comments (1)

tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-miscoffice-module/src/main/java/org/apache/tika/parser/geogebra/GeoGebraParser.java:388

• The inline comment here is too specific: this skip applies to whatever entry was emitted as the representative thumbnail (worksheet thumbnail, slide thumbnail, or tool icon), not only a tool icon. Updating the comment will prevent confusion when reading the loop logic later.

            if (name.equals(thumbnail)) {
                //already emitted as the thumbnail (a tool icon)
                continue;
            }

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[dschmidt]

Merged into one.