[Arith] Simplify floordiv(x*8+7, 16) to floordiv(x, 2) - #10232
Merged
kparzysz-quic merged 1 commit intoFeb 14, 2022
Merged
Conversation
wrongtest-intellif
requested review from
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
merrymercy,
tqchen,
vinx13 and
yzhliu
as code owners
February 12, 2022 16:22
kparzysz-quic
approved these changes
Feb 13, 2022
kparzysz-quic
left a comment
Contributor
There was a problem hiding this comment.
The math checks out. The rest looks ok as well.
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Feb 16, 2022
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, the PR add a simplify rule to allow patterns like floordiv(x*8+7, 16) => floordiv(x, 2).
We find the issue when using compute_at to
repeatop:compute_at(
T_add,i0_0) currently will result to a "dynamic" extentfloordiv(x*8 + 7, 16) - floordiv(x, 2) + 1.Also fix a typo of previous compute at testcase.