[Relay] Make DeviceAnalyzer a mixed mode visitor - #10248
Merged
Merged
Conversation
masahi
requested review from
MarisaKirisame,
ZihengJiang,
anijain2305,
areusch,
comaniac,
icemelon,
jroesch,
junrushao,
jwfromm,
mbrookhart,
merrymercy,
slyubomirsky,
tqchen,
vinx13,
wweic,
yzhliu and
zhiics
as code owners
February 15, 2022 03:19
masahi
commented
Feb 15, 2022
| * | ||
| * TODO(mbs): Rename VirtualDevice |-> VirtualDevice, and use 'virtual device' (or just 'device') | ||
| * throughout. | ||
| * |
masahi
force-pushed
the
device-planner-mixed-mode
branch
from
February 15, 2022 08:48
bf9c637 to
0708bf7
Compare
Contributor
|
Thank you @mbrookhart and @masahi - PR has been merged. |
Contributor
|
I confirmed that this fixes the issue I saw on windows. Thanks! |
ylc
pushed a commit
to ylc/tvm
that referenced
this pull request
Feb 16, 2022
* hack to ExpandDataflow * add test from mei * Update DeviceAnalyzer to inherit from MixedModeVisitor * indent
pfk-beta
pushed a commit
to pfk-beta/tvm
that referenced
this pull request
Apr 11, 2022
* hack to ExpandDataflow * add test from mei * Update DeviceAnalyzer to inherit from MixedModeVisitor * indent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10135
There are about 5 visitors / mutators in
device_planner.cc, but only one of them is mixed mode for now following @mei-ye's original PR.@mei-ye Please confirm if this fixes the issue on windows.
cc @mbrookhart @mbs-octoml @tmoreau89
One issue with making
DeviceAnalyzerinherit fromMixedModeVisitoris the intermediate tuple incall_loweredop, as inIf we do pure post-DFS traversal, the tuple will be visited before
call_lowered, and that makes all originalCallNodeargs unify to the domain of the tuple. The solution we agreed upon is to updateExpandDataflowfunction to ignore that tuple when it expandscall_loweredop.