Skip to content

[CI] Assert some unittests are not skipped in CI - #12436

Merged
driazati merged 3 commits into
apache:mainfrom
gigiblender:tests-report
Aug 25, 2022
Merged

driazati merged 3 commits into
apache:mainfrom
gigiblender:tests-report

Conversation

@gigiblender

@gigiblender gigiblender commented Aug 15, 2022

Copy link
Copy Markdown
Contributor

This PR adds a script that does a diff of skipped tests between the latest successful build on the main and the current branch. Then, it posts a comment with the report on the open PR.

#11670

@driazati @areusch

cc @Mousius

@gigiblender gigiblender changed the title [CI] Assert some unittests are not skipped [CI] Assert some unittests are not skipped in CI Aug 15, 2022
@github-actions

Copy link
Copy Markdown
Contributor

Built docs for commit 183f513 can be found here.

@driazati driazati left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty great! This is a nice way to fix this without putting too much burden on developers. It’d be nice to see a end to end test in your tvm fork too

Comment thread tests/scripts/github_skipped_tests_comment.py Outdated

ghost left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

general structure looks good, just a couple more small comments

Comment thread tests/python/ci/test_ci.py Outdated
Comment thread tests/python/ci/test_ci.py Outdated
Comment thread tests/scripts/github_skipped_tests_comment.py Outdated
Comment thread tests/scripts/github_skipped_tests_comment.py Outdated
Comment thread tests/scripts/github_skipped_tests_comment.py
Comment thread tests/python/ci/test_ci.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants