Skip to content

[SVE] Add vscale builtin - #16484

Merged
Hzfengsy merged 2 commits into
apache:mainfrom
ekalda:add-vscale-intrinsic
Jan 31, 2024
Merged

Hzfengsy merged 2 commits into
apache:mainfrom
ekalda:add-vscale-intrinsic

Conversation

@ekalda

@ekalda ekalda commented Jan 29, 2024

Copy link
Copy Markdown
Contributor

Add a vscale builtin and lowering to llvm.vscale. This will be used in subsequent patches for expressing scalable vectors in TIR.

@ekalda

ekalda commented Jan 29, 2024

Copy link
Copy Markdown
Contributor Author

cc @lhutton1 @neildhickey

@lhutton1 lhutton1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had one small suggestion, but otherwise looks good to me!

also cc @tqchen @cbalint13 @Lunderberg @kparzysz-quic

Comment thread include/tvm/tir/builtin.h Outdated
Comment thread tests/python/codegen/test_target_codegen_aarch64.py Outdated

@cbalint13 cbalint13 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

ekalda and others added 2 commits January 30, 2024 10:42
Add a vscale builtin and lowering to `llvm.vscale`. This will be used in
subsequent patches for expressing scalable vectors in TIR.

Co-authored-by: Luke Hutton <luke.hutton@arm.com>
Co-authored-by: Neil Hickey <neil.hickey@arm.com>
Change-Id: I5b364a8b50c8622d21d3d6d30b9d44a56e0418db
@ekalda
ekalda force-pushed the add-vscale-intrinsic branch from 98a3eb3 to f6a1660 Compare January 30, 2024 11:35
@Hzfengsy
Hzfengsy merged commit 06f7810 into apache:main Jan 31, 2024
@ekalda
ekalda deleted the add-vscale-intrinsic branch January 31, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants