Skip to content

[AutoScheduler] Improve warning messages - #6935

Merged
merrymercy merged 2 commits into
apache:mainfrom
merrymercy:pr-improve-warning
Nov 18, 2020
Merged

merrymercy merged 2 commits into
apache:mainfrom
merrymercy:pr-improve-warning

Conversation

@merrymercy

Copy link
Copy Markdown
Member

Improve the warning messages for #6903

Comment on lines -227 to +238
wrap_topi_schedule(tvm.te.create_schedule),
naive_schedule, # this implementation should never be picked by autotvm

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tvm.te.create_schedule is not a valid topi schedule. Their signatures are different. So I created a new one.

@comaniac comaniac left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just a nit

raise RuntimeError(
"Cannot compile for GPU targets if no tuned schedule is found. Please see the warning messages above for more information about the failed workloads."
)
return tvm.te.create_schedule(outs[-1].op)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we need to add a comment saying that it would be a problem for the DAG with multiple outputs.

@merrymercy
merrymercy merged commit 7649075 into apache:main Nov 18, 2020
@merrymercy
merrymercy deleted the pr-improve-warning branch November 18, 2020 19:13
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Dec 2, 2020
* [AutoScheduler] Improve warning messages

* fix lint
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Dec 4, 2020
* [AutoScheduler] Improve warning messages

* fix lint
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Dec 4, 2020
* [AutoScheduler] Improve warning messages

* fix lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants