Fix QNN type inference - #7074
Conversation
|
@anijain2305 So after #6704, it seems type inferencer can pass |
masahi
left a comment
There was a problem hiding this comment.
Thank you very much!! @mbrookhart
|
I'm a little confused what exactly is being type checked. The comments say its scale and zero points but the number of checked types in the loop don't match up. A little better documentation would go a long way. |
|
@jwfromm These functions are a little odd, they often check types for some of the scales/zero points and then run assignments on others I would expect to be inputs. I assume there is a reason for this, perhaps @anijain2305 knows? Anyway, to make it work, I only added the return false on those input types we actually end up checking. I just pushed a bunch of comments for what we expect in the types vector, I hope that helps. |
|
Thanks @mbrookhart @jwfromm |
* check for incomplete types in QNN Relation functions * add regression test from apache#7067 * respond to review comments
* check for incomplete types in QNN Relation functions * add regression test from apache#7067 * respond to review comments
* check for incomplete types in QNN Relation functions * add regression test from apache#7067 * respond to review comments
@masahi @anijain2305
Fix for #7067