Skip to content

[Runtime][Contrib][Verilator] remove explicit destructor call - #7485

Merged
tqchen merged 3 commits into
apache:mainfrom
vegaluisjose:e3
Mar 10, 2021
Merged

tqchen merged 3 commits into
apache:mainfrom
vegaluisjose:e3

Conversation

@vegaluisjose

Copy link
Copy Markdown
Member

Hey @liangfu,

This is the fix you found in #7406. Thanks for catching that.

cc: @tmoreau89

@liangfu

liangfu commented Feb 22, 2021

Copy link
Copy Markdown
Member

Thanks @vegaluisjose for bringing the update. Do we need to add delete _lib statement to perform the clean up?

@tmoreau89 tmoreau89 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @liangfu let me know if you'd like to request changes

@tqchen
tqchen merged commit 8a9aebc into apache:main Mar 10, 2021
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants