Skip to content

[Relay][dismantler] Added handling of packed func - #8004

Merged
mbrookhart merged 1 commit into
apache:mainfrom
d-smirnov:deleter
May 25, 2021
Merged

mbrookhart merged 1 commit into
apache:mainfrom
d-smirnov:deleter

Conversation

@d-smirnov

Copy link
Copy Markdown
Contributor

Added handling of CallNode objects created via packed functions invocation + test cases. Related to #7832
@mbrookhart

@mbrookhart

Copy link
Copy Markdown
Contributor

Can you add some comments to this? It's not clear why there need to be multiple deleter attributes in the CallNode class.

@d-smirnov

Copy link
Copy Markdown
Contributor Author

There is a need to preform additional action and to preserve original deleter as well, hence an extra field for CallNode

@mbrookhart

Copy link
Copy Markdown
Contributor

Can you add some comments to the code to explain what this is doing?

Added handling of CallNode objects created via packed
functions invocation + test cases.

Change-Id: I5374abc59a3b0f79f27364c45f1a5789536df940
@d-smirnov
d-smirnov requested a review from mbrookhart May 25, 2021 08:49
@mbrookhart
mbrookhart merged commit aefa0c8 into apache:main May 25, 2021
@mbrookhart

Copy link
Copy Markdown
Contributor

Thanks @d-smirnov

trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Jun 17, 2021
Added handling of CallNode objects created via packed
functions invocation + test cases.

Change-Id: I5374abc59a3b0f79f27364c45f1a5789536df940
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Jun 17, 2021
Added handling of CallNode objects created via packed
functions invocation + test cases.

Change-Id: I5374abc59a3b0f79f27364c45f1a5789536df940
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants