Skip to content

[BYOC][NNAPI]: Add testing package to ci_cpu image - #8088

Merged
mbrookhart merged 1 commit into
apache:mainfrom
melsonlai:nnapi_ci
Jun 22, 2021
Merged

mbrookhart merged 1 commit into
apache:mainfrom
melsonlai:nnapi_ci

Conversation

@melsonlai

Copy link
Copy Markdown
Contributor

This commit adds Android SDK to the ci_cpu image for supporting tests of Android NNAPI BYOC.

See also:

Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.

This commit adds Android SDK to the ci_cpu image for supporting tests of Android NNAPI BYOC.
@melsonlai

Copy link
Copy Markdown
Contributor Author

cc @comaniac @zhiics

@leandron leandron left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @melsonlai, thanks for the PR.

LGTM.

@comaniac comaniac left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Link #7995 that is tracking CI updating. Also cc @areusch

@areusch

areusch commented May 20, 2021

Copy link
Copy Markdown
Contributor

hi all, i added some updates on #7995 to let you know where we are. given the complexity there, i'd prefer if we could keep this PR out of it and then we can update again after that. The CUDA issues encountered on 18.04 are making this container update more challenging than normal.

@comaniac

Copy link
Copy Markdown
Contributor

Accordingly, we will put this PR on hold for now, and @areusch will merge it when the issues of updating container images are resolved.

@areusch

areusch commented Jun 4, 2021

Copy link
Copy Markdown
Contributor

@melsonlai @comaniac #7995 has landed, since the CI did not fail before, i'm unsure whether we should retest before merging?

@areusch

areusch commented Jun 4, 2021

Copy link
Copy Markdown
Contributor

oh sorry, i was just sorting through PRs now and not reading very well. do we now want to move forward with this PR and rebuild containers again?

@comaniac

comaniac commented Jun 4, 2021

Copy link
Copy Markdown
Contributor

Sure we could do that. Please merge this PR when you are going to rebuild the container.

@mbrookhart
mbrookhart merged commit 41b4872 into apache:main Jun 22, 2021
@mbrookhart

Copy link
Copy Markdown
Contributor

Rebuilding containers this week.

Thanks @melsonlai @areusch @comaniac @leandron

@melsonlai

Copy link
Copy Markdown
Contributor Author

Hi, had the ci_cpu container been updated? It's seems that Android SDK is still not there in the Jenkins pipeline.

@mbrookhart

Copy link
Copy Markdown
Contributor

Still working on it :( We've hit lots of incompatible versions and typos in install scripts. See #8177 for details

@melsonlai
melsonlai deleted the nnapi_ci branch July 7, 2021 07:54
ylc pushed a commit to ylc/tvm that referenced this pull request Sep 29, 2021
This commit adds Android SDK to the ci_cpu image for supporting tests of Android NNAPI BYOC.
zxy844288792 pushed a commit to zxy844288792/tvm that referenced this pull request Mar 4, 2022
This commit adds Android SDK to the ci_cpu image for supporting tests of Android NNAPI BYOC.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants