Skip to content

[CI] Install curl in the context of ubuntu_install_nodejs.sh - #8326

Merged
leandron merged 1 commit into
apache:mainfrom
leandron:curl_installation
Jun 25, 2021
Merged

leandron merged 1 commit into
apache:mainfrom
leandron:curl_installation

Conversation

@leandron

Copy link
Copy Markdown
Contributor

Make sure that curl is installed, as this script is used on ci_lint, which does not need all the packages installed by ubuntu_install_core.sh

This partially undo what is done in #8310, that causes an unexpected failure when rebuilding ci_lint

cc @mbrookhart @u99127 for reviews

@u99127 u99127 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you leave a comment around it ?

 * Make sure that curl is installed, as this script is used on
   ci_lint, which does not need all the packages installed by
   ubuntu_install_core.sh
@leandron

Copy link
Copy Markdown
Contributor Author

Can you leave a comment around it ?

Done.

@u99127 u99127 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - sorry about missing it.

@leandron
leandron merged commit aa56cc1 into apache:main Jun 25, 2021
@leandron

Copy link
Copy Markdown
Contributor Author

This is merged now, thanks @u99127 @tqchen !

@leandron
leandron deleted the curl_installation branch June 25, 2021 08:23
ylc pushed a commit to ylc/tvm that referenced this pull request Sep 29, 2021
…8326)

* Make sure that curl is installed, as this script is used on
   ci_lint, which does not need all the packages installed by
   ubuntu_install_core.sh
zxy844288792 pushed a commit to zxy844288792/tvm that referenced this pull request Mar 4, 2022
…8326)

* Make sure that curl is installed, as this script is used on
   ci_lint, which does not need all the packages installed by
   ubuntu_install_core.sh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants