shim: refactor nodejs shim to work on node8 or node10 - #778
Closed
skabbes wants to merge 1 commit into
Closed
Conversation
This was referenced Aug 27, 2019
Closed
Contributor
Author
|
Several hours on node8, and coming up on 24 hours on a few sites that gets probably 1QPS in aggregate for node10. Still not sure that "runtime" is the best way to expose whether you want node8 or node10. It is going to be forever confusing due to the "proxy runs on X platform, your code runs Y". |
Contributor
Author
|
Over 1 week of testing "in production" on a node.js server running node10. And several "static" sites as well, no problem - all running smoothly. I used to embed node10 directly in the lambda package, and saved so much extra space not having to do that anymore. Now, I have so much more room for |
Member
|
Whoop! I'll check this out again when I'm back from NYC next week! |
3 tasks
Member
|
merged! thanks man! |
|
Thank you @skabbes ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No breaking changes to any code, you can simply specify:
to select the nodejs 10.x runtime on AWS. The node 8 runtime will continue to work, as the shim is compatible with both versions of node.
I have run this against our company's internal website with no issue (node 8), and will run on node10 this afternoon to burn that in too.