Skip to content

Move iframe-render script earlier to run it as fast as possible - #248

Merged
VladyslavTy merged 2 commits into
juniper/mainfrom
hide-html-elements-in-iframe
Aug 27, 2024
Merged

VladyslavTy merged 2 commits into
juniper/mainfrom
hide-html-elements-in-iframe

Conversation

@VladyslavTy

Copy link
Copy Markdown
Contributor

Change description

Move the script earlier in head, so it should initialize faster and improve the speed of hiding elements.

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

Comment thread lms/templates/main.html
@VladyslavTy
VladyslavTy merged commit 644e572 into juniper/main Aug 27, 2024
@VladyslavTy
VladyslavTy deleted the hide-html-elements-in-iframe branch August 27, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants