Skip to content

Add support for Edxapp Extra Requirements - #77

Merged
iamjazzar merged 2 commits into
masterfrom
jazzar/extra-requirements
Aug 12, 2021
Merged

iamjazzar merged 2 commits into
masterfrom
jazzar/extra-requirements

Conversation

@iamjazzar

@iamjazzar iamjazzar commented Aug 11, 2021

Copy link
Copy Markdown
Contributor

Change description

Add support to EDXAPP_EXTRA_REQUIREMENTS. These requirements are used in production Ansible deployment scripts, but never were incorporated in the devstack.

@OmarIthawi introduced a way in our devstack (devstack#42) to install extra pip packages without modifying edx-platform. This PR introduces a new configuration variable (EDXAPP_EXTRA_REQUIREMENTS) that utilizes Omar's work, so it won't work on any devstack except Appsembler's, unfortunately.

The configuration variable expects a comma-separated list of pip packages git repos:

EDXAPP_EXTRA_REQUIREMENTS="https://github.com/appsembler/gestore.git==0.1.0-dev3,https://github.com/appsembler/course-access-groups.git"

To specify the version, simply add ==<branch_or_tag> after the repo link. If no version is specified, we will default to the main branch of the repo.

If the package you're installing is a Django app, then you might need to consider adding the app name to your ADDL_INSTALLED_APPS in your lms/cms YAML configs.

Note

This change is based on #76 (Hence first commit), so I won't be merging it until the PR is approved and merged.

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related PRs

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@iamjazzar iamjazzar changed the title Jazzar/extra requirements Add support for Edxapp Extra Requirements Aug 11, 2021
@iamjazzar
iamjazzar force-pushed the jazzar/extra-requirements branch from 0dfe6fc to 0de0de6 Compare August 11, 2021 20:50
@iamjazzar
iamjazzar force-pushed the jazzar/extra-requirements branch from 0de0de6 to a8a6c31 Compare August 12, 2021 19:24
@iamjazzar
iamjazzar merged commit 048f26a into master Aug 12, 2021
@iamjazzar
iamjazzar deleted the jazzar/extra-requirements branch August 12, 2021 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants