Fix/s3 pubilshing - #1241
Merged
Merged
Conversation
neolynx
requested review from
a team,
dario-gallucci,
randombenj and
szakalboss
January 13, 2024 13:09
neolynx
force-pushed
the
fix/s3-publshing
branch
from
January 21, 2024 19:54
01ac631 to
2a5c4be
Compare
as per contributor instructions
instead of caching the whole s3 bucket, cache only the pool path. this requires an additional parameter, and since this is an interface, all implementations need to follow. might help in other backends too. closes #1181
When a publishing uses a publish prefix, instead of listing the contents of the whole bucket under the storage prefix, only list the contents of the bucket under the storage prefix and publish prefix, and cache it by publish prefix. This speeds up publish operations under a prefix.
neolynx
force-pushed
the
fix/s3-publshing
branch
from
February 5, 2024 12:31
012f43f to
d62ddcc
Compare
szakalboss
approved these changes
Feb 5, 2024
dario-gallucci
approved these changes
Feb 5, 2024
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1223
Description of the Change
Checklist
AUTHORS