Skip to content

Editing repo via api 404 - #1493

Merged
neolynx merged 1 commit into
aptly-dev:masterfrom
Daedaluz:fix/update-repo-api
Nov 8, 2025
Merged

Editing repo via api 404#1493
neolynx merged 1 commit into
aptly-dev:masterfrom
Daedaluz:fix/update-repo-api

Conversation

@Daedaluz

Copy link
Copy Markdown
Contributor

Editing repo via

Fixes #1453

Description of the Change

This fixes the repo edit api by correcting the logic that checks if the target repo name already exists.
Also, replies with an error describing the issue instead of an empty 404 reply

Checklist

  • unit-test added (if change is algorithm)
  • functional test added/updated (if change is functional)
  • man page updated (if applicable)
  • bash completion updated (if applicable)
  • documentation updated
  • author name in AUTHORS

@neolynx neolynx self-assigned this Oct 19, 2025
@cfiehe

cfiehe commented Nov 8, 2025

Copy link
Copy Markdown
Contributor

@neolynx
The change looks good to me. It solves the problem that updating an existing repo fails when you have the same repo name in the body of your put request. The logic before considered that there is always a change in the repo's name when the name field is part of the message body.

@neolynx
neolynx requested review from a team and cfiehe November 8, 2025 12:09
@neolynx
neolynx merged commit 132c923 into aptly-dev:master Nov 8, 2025
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

API: HTTP 404 on PUT repo update request

3 participants