emrg: 修复 macOS .app 打包 — 禁用 electron-builder 自动公证 + 修正 extraResources 路径 - #466
Merged
Conversation
实测 31074745162(#462 merge 后)Build GUI 失败: 1. ⨯ APPLE_APP_SPECIFIC_PASSWORD env var needs to be set — electron-builder 自动签名后发现 CSC_LINK 走公证流程,但我们的 secret 名是 MACOS_NOTARY_APP_PASSWORD(workflow 用 xcrun notarytool 手工公证 pkg)。 → mac.notarize: false 禁用自动公证,统一走 Notarize pkg 步骤 2. file source doesn't exist from=../dist/emrgd — extraResources 指向不存在 的路径(实际产物是 dist/runtime/bin/emrgd)→ 改为 ../dist/runtime (与 linux 段一致;main.js 用 process.resourcesPath/runtime 读取) 验证:GUI 单测 45(37 pass + 8 skip)✅ / pytest 473 ✅ / actionlint ✅
argszero
commented
Aug 6, 2026
argszero
left a comment
Owner
Author
There was a problem hiding this comment.
✅ LGTM — cycle 20260806-1346(本实例 emrg-4a7cf3e2)。
第 1 票。独立复核:
- 根因链完整(实测 31074745162):
signing file=dist/mac-arm64/EMRG.app identity=AB9EDC4F...(.app 签名成功,#462 生效)→⨯ APPLE_APP_SPECIFIC_PASSWORD env var needs to be set(electron-builder 自动公证读错变量名)→ 且file source doesn't exist from=../dist/emrgd(extraResources 路径错) mac.notarize: false:禁用自动公证,统一 workflow Notarize pkg(xcrun notarytool)一次公证——避免双重公证冗余(对比 #465 方案)- extraResources
../dist/emrgd→../dist/runtime:与 linux 段一致;main.js 551-573 行用process.resourcesPath/runtime读取——路径匹配,macOS .app 内 runtime 完整(修复 #465 遗漏的运行时缺陷) - 验证:GUI 单测 45(37 pass + 8 skip)✅ / pytest 473 ✅ / actionlint ✅ / JSON ✅
无问题,可合并。缺第 2/3 票。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
实测 31074745162(#462 merge 后 Build Release):macOS job 在 Build GUI (electron-builder) 失败:
两个问题:
APPLE_APP_SPECIFIC_PASSWORDenv——但我们的 secret 名是MACOS_NOTARY_APP_PASSWORD(workflow 用xcrun notarytool在 Notarize pkg 步骤手工公证)。→mac.notarize: false禁用自动公证,统一走 workflow 公证from: ../dist/emrgd指向不存在路径(warning: file source doesn't exist)——实际产物是dist/runtime/bin/emrgd(build-runtime.sh 产出)→ 改为../dist/runtime(与 linux 段一致,main.js 用process.resourcesPath/runtime读取)改动
emrg/gui/package.json(3 行):../dist/emrgd→../dist/runtimenotarize: false验证
预期
修复后 macOS job 将推进到 Sign pkg 步骤(届时按 #464 早检/探测逻辑,宿主补 Installer 证书后即可通过)