Skip to content

emrg: evolution_prompt quick-ref — add #545 GCM silent-fail + #546 Windows TUI input & /rant visibility entries - #547

Merged
argszero merged 1 commit into
masterfrom
feature/quickref-545-546
Aug 7, 2026
Merged

emrg: evolution_prompt quick-ref — add #545 GCM silent-fail + #546 Windows TUI input & /rant visibility entries#547
argszero merged 1 commit into
masterfrom
feature/quickref-545-546

Conversation

@argszero

@argszero argszero commented Aug 7, 2026

Copy link
Copy Markdown
Owner

Adds the two most recently merged feature entries to the evolution_prompt implemented-features quick reference, so future evolution cycles do not re-discover/re-implement them:

  1. emrg: Windows GCM silent-fail stage 1 — no_prompt_env for all git/gh subprocess + github_status command + prompt platform guards #545 — Windows GCM silent-fail: no_prompt_env() 3-guard env for all git/gh subprocesses (bash_tool, 8 scheduler sites, git_cmd), github_status daemon command with parse_gh_auth_user (as/account forms), prompt platform guards (Windows skips git credential fill → GUI pointer). +12 tests (508→520).

  2. emrg: fix Windows TUI CJK input + legacy arrow keys + /rant project visibility #546 — Windows TUI input + /rant visibility: ENABLE_VIRTUAL_TERMINAL_INPUT in raw mode (with pre-Win10-1607 fallback), legacy 0xE0/0x00 scan-code normalization gated on recognized codes (disjoint from UTF-8 continuation bytes), _handle_list_projects evolution-filter removal (_touch_project preserved). +12 tests (520→534, incl. discriminating regression tests for Thai/Devanagari/Ctrl+@/split-read).

Doc-only change (+2 lines). 534 tests pass; prompt-build tests pass.

…ndows TUI input & /rant visibility entries

@argszero argszero left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle 20260807-194347 (1st review; angle: content accuracy + format)

Doc-only PR (+2 lines to evolution_prompt.md quick-ref). Verified:

Content accuracy — each claim cross-checked against the merged code:

  • #545 entry: no_prompt_env 3 guards (GIT_TERMINAL_PROMPT=0 / GCM_INTERACTIVE=never / GIT_ASKPASS=) ✓; application to bash_tool + all 8 scheduler git subprocess sites + git_cmd ✓; github_status daemon command ✓; parse_gh_auth_user as/account dual-form parsing ✓; prompt platform guards (Windows skips git credential fill → GUI pointer) ✓; +12 tests 508→520 ✓
  • #546 entry: ENABLE_VIRTUAL_TERMINAL_INPUT 0x0200 + pre-Win10-1607 fallback ✓; legacy 0xE0/0x00 scan-code normalization gated on 0x47-0x53 (disjoint from UTF-8 continuation 0xA0-0xBF) ✓; parse_keypress direct KeyName mapping ✓; /rant filter removal with rationale (#78 obsolete, #489/#490/#535 self-heal) ✓; _touch_project preserved ✓; +12 tests 520→534 incl. discriminating regressions (Thai/Devanagari/Ctrl+@/split-read) ✓

Format: both entries match the established pattern (> - Feature (#NN rant ...) ✅), placed after #543 in chronological order; 0 {{ braces (Jinja2-safe); 90 ✅ entries total consistent.

Verification: 3 prompt-build tests pass (Jinja2 rendering intact); full suite 534 passed.

CI was pending at review time (31175157292) — expected for a fresh push, not a failure.

Vote: 1/3.

@argszero argszero left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle 20260807-194613 (2nd review; angle: mergeability + format consistency)

Mergeability: MERGEABLE + mergeable_state=clean + rebaseable=true; 0 conflict markers; head 99e1e6d unchanged since review 1.

Scope discipline: diff is exactly 2 insertions in emrg/server/evolution_prompt.md — nothing else touched (no tests, no code, no other docs).

Format consistency with neighbors:

  • Both entries follow the established pattern: > - <Feature name> (#NN rant ...) ✅
  • #545 entry: Windows GCM silent-fail (#545 rant 10:17 ...)
  • #546 entry: Windows TUI input + /rant visibility (#546 rant 10:38 ...)
  • Placed chronologically after the #543 entry, matching the file's ordering convention ✓
  • Zero Jinja2 {{ braces in the additions (render-safe; prompt-build tests pass) ✓

CI: green (31175157292); mergeStateStatus CLEAN.

Full suite: 534 passed locally.

Vote: 2/3.

@argszero argszero left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle 20260807-194847 (3rd review; angle: rendering safety + content anchors)

Rendering safety:

  • Both added lines contain zero {{ / {% Jinja2 sequences — cannot break template substitution. Verified by grep and by the 3 prompt-build tests (emrg_self / all_variables_substituted / with_project) passing on this branch.
  • The lines are plain markdown blockquotes (> - ...) exactly like their neighbors — no markdown-structure risk.

Content anchors exist in code (every symbol the entries claim was verified against the merged implementation):

  • #545 entry anchors: no_prompt_env (git_utils.py), github_status (daemon.py), parse_gh_auth_user (git_utils.py), the 3 env guards — all present ✓
  • #546 entry anchors: ENABLE_VIRTUAL_TERMINAL_INPUT (win32.py), normalize_legacy_scan_codes (events.py), _handle_list_projects (daemon.py) — all present ✓
  • Test-count claims (508→520, 520→534) match the actual repo history ✓

Merge readiness: head 99e1e6d unchanged across all 3 reviews; MERGEABLE + CLEAN; CI green (31175157292); full suite 534 passed locally this cycle.

Vote: 3/3 — merge gate satisfied (3 consecutive ✅ from different cycles: 194347 content accuracy, 194613 mergeability+format, 194847 render safety+anchors; no ❌ between).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant