emrg: evolution_prompt quick-ref — add #587 Windows tree-kill entry - #588
Merged
Conversation
argszero
commented
Aug 9, 2026
argszero
left a comment
Owner
Author
There was a problem hiding this comment.
✅ LGTM — cycle. Quick-ref accurately describes #587: killProcessTree win32 taskkill /T /F (windowsHide, stdio ignore, errors swallowed), POSIX group-kill unchanged, killDaemon SIGTERM→3s→SIGKILL + stale-port test both via helper; pure test change (21+/3-, counts unchanged). Matches merged #587 (b17f9bc).
argszero
commented
Aug 9, 2026
argszero
left a comment
Owner
Author
There was a problem hiding this comment.
✅ LGTM — cycle
Quick-ref entry for #587 (Windows integration-test tree-kill, G130). Pure evolution_prompt.md documentation: 1-line insertion describing the fix (taskkill /PID /T /F tree-kill on win32 vs POSIX group-kill), test-only change with no doc-count impact. Verified on master post-merge: 639 pytest + 96 GUI green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick-reference update for the evolution prompt after merging #587.
Adds an entry for #587 (external contribution pm25coder, G130): Windows integration tests used
process.kill(-pid)(POSIX process-group kill) which is unsupported on Windows (negative PIDs → ESRCH), leaving orphan daemons; the fix routes both kill call sites through a newkillProcessTreehelper usingtaskkill /PID <pid> /T /Fon win32 while keeping POSIX group-kill unchanged. Test-only change, no doc-count impact.