emrg: cmd launchers — ASCII-only REM comments (CP936 mojibake, host 01:36:12Z note) - #610
Conversation
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle 20260810-093935. Verified on checkout: all three cmd files are now pure ASCII (0 non-ASCII bytes via Python byte check), diff of non-REM lines is empty (zero executable-line changes — behavior-neutral as claimed), tests/test_installer_stop.py 4/4 pass (content assertions still match), full suite 674 green, import + CLI OK. This addresses the host's CP936 mojibake note (pm25coder 01:36:12Z on #608) — spotless console on zh-CN Windows.
|
I tested this PR on the real Windows host (zh-CN, CP936 console) — the exact environment where the mojibake was observed. Claim verification — zero executable-line changes
Discriminating real-host run (throwaway copy with fake image name
The fix is behavior-neutral as claimed and the CP936 mojibake is completely gone on the real zh-CN host. No issues found. |
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle
Reviewed feature/cmd-comments-ascii (b70cdec): all non-ASCII REM comments in bin/emrg.cmd, bin/emrgd.cmd, bin/stop-emrg.cmd converted to ASCII-only equivalents (Chinese/em-dash/section-sign → plain ASCII), preserving meaning and all referenced identifiers (rant ids, paths, %-variable warnings). Zero executable-line changes — every command line byte-identical; test count unchanged (674). Verified this cycle: full suite 674 passed, doc counts green, tests/test_installer_stop.py 4/4, import + CLI green. Addresses the host's 01:36:12Z CP936 mojibake note (spotless zh-CN console).
…or bundling entries (#613) Merged feature PRs #610 (cmd launchers ASCII-only REM comments, CP936 mojibake) and #612 (GUI packaged vendor bundling — electron-builder files whitelist vendor/** + diagnostic markdown fallback) were merged without quick-ref entries. Add both to the implemented-features quick reference so future cycles cross-check them as handled and avoid duplicate work. - 2 entries appended after #608 in the quick-ref table - No {cmd}/{tmp} template constants introduced (prompt-substitution guard) - 674 pytest full suite green incl. test_build_prompt_all_variables_substituted + doc-count guard Co-authored-by: EMRG Evolution <emrg@argszero.dev>
Follow-up to the host's cosmetic note on #608 (pm25coder @ 2026-08-10T01:36:12Z):
Change (REM comment lines only, behavior-neutral):
Verified: full suite 674 passed, doc counts green, import + CLI green, tests/test_installer_stop.py 4/4 (its content assertions still match).