Skip to content

emrg: evolution_prompt quick-ref for #651 (GUI packaged local-module whitelist guard) - #652

Merged
argszero merged 1 commit into
masterfrom
feature/quickref-651
Aug 10, 2026
Merged

emrg: evolution_prompt quick-ref for #651 (GUI packaged local-module whitelist guard)#652
argszero merged 1 commit into
masterfrom
feature/quickref-651

Conversation

@argszero

Copy link
Copy Markdown
Owner

Summary

Adds the implemented-features quick-ref entry for PR #651 (GUI packaged local-module whitelist guard, rant 2026-08-10T20:37:08) to emrg/server/evolution_prompt.md, following the established quick-ref convention for merged user-facing fixes.

The entry documents:

  • The v0.2.21 packaged-GUI crash root cause: conn-manager.js + gui-state.js missing from electron-builder files whitelist (same failure class as emrg: bundle vendor scripts in GUI package — fix packaged Markdown fallback #612 vendor/**)
  • The fix: whitelist entries + the generalized require-coverage guard in build-config.test.js (every main.js/preload.js local require must be whitelisted) — closing the entire "forgot to whitelist a new module" bug class
  • Verification (GUI 179/179, pytest 681, doc guard 3/3) and that packaged builds are fixed from v0.2.22 onward

Meta/documentation-only change (1 line added). No source code touched.

@argszero argszero left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle

Verified (cycle 502):

  • 1-line docs addition to evolution_prompt.md quick-ref documenting #651 (GUI packaged local-module whitelist guard)
  • Content accurate: root cause (conn-manager.js + gui-state.js missing from electron-builder files whitelist → v0.2.21 packaged crash), fix (whitelist entries + require-coverage guard test), closes the #612/#651 'new local module forgot whitelist' class
  • Docs-only — no test count impact; CI (test run 31390039585) SUCCESS

@argszero argszero left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle. Verified: single-line quick-ref addition for #651 (GUI packaged local-module whitelist guard) placed after the #649 entry; documents the conn-manager.js/gui-state.js whitelist fix + require-coverage guard closing the #612/#651 class; content matches merged master state (acd4d65). CI test green (run 31390039585).

@argszero argszero left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle

Re-verified (cycle 503):

  • Head 2c1259e unchanged, mergeable (mergeState CLEAN)
  • 1-line docs quick-ref for #651 (GUI packaged local-module whitelist guard) — accurate, docs-only
  • CI (test run 31390039585) still SUCCESS
  • 3 consecutive LGTMs from different cycles (502, parallel, 503) — merge condition met

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant