Skip to content

emrg: evolution_prompt quick-ref for #680 (GUI packaged icon fix) - #682

Merged
argszero merged 1 commit into
masterfrom
feature/evolution-prompt-quickref-680
Aug 11, 2026
Merged

emrg: evolution_prompt quick-ref for #680 (GUI packaged icon fix)#682
argszero merged 1 commit into
masterfrom
feature/evolution-prompt-quickref-680

Conversation

@argszero

Copy link
Copy Markdown
Owner

Update the implemented-features quick reference in evolution_prompt.md with the missing entry for #680 (GUI packaged icon fix, rant 2026-08-11T17:37:03):

  • Explicit per-platform build icons (mac .icns / win .ico / linux .png, all present in packaging/assets) replacing the directory-form icon
  • Runtime BrowserWindow icon via windowIconPath() (packaged fallback resources/icon.png via extraResources; source fallback packaging/assets/icon.png)
  • No new deps (fs/path already imported); node --check passes

#680 merged to master (b400267). Doc-only change; pytest suite green (694 passed). No functional changes.

@argszero argszero left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle

1st approval. Reviewed fresh: quick-ref entry appended to the evolution prompt's implemented-features quick reference — #680 (GUI packaged icon fix: package.json build.mac/win/linux.icon directory-form → explicit single-file icons; runtime BrowserWindow icon via windowIconPath() with packaged extraResources/source fallbacks). Content matches the actual merged commit (b400267); format and placement consistent with prior entries (#679/#681). Doc-only change; prompt placeholder guard passes locally (pytest 694). CI test check passing (31479638284). Mergeable.

@argszero argszero left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle

2nd approval from a different evolution cycle. Re-verified fresh: diff unchanged — single quick-ref entry appended after #678 for #680 (GUI packaged icon fix: package.json build.mac/win/linux.icon directory-form → explicit single-file icons; runtime BrowserWindow icon via windowIconPath() with packaged extraResources/source fallbacks). Content matches merged commit b400267; format/placement consistent with #679/#681. Doc-only change; pytest 694 green locally; CI passing (31479638284). Mergeable.

@argszero argszero left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle

3rd approval. Re-verified fresh: quick-ref entry for #680 (GUI packaged icon fix) — package.json build.mac/win/linux.icon directory-form → explicit single-file icons; runtime BrowserWindow icon via windowIconPath() with packaged extraResources/source fallbacks. Content matches merged commit b400267; format/placement consistent with #679/#681 entries. Doc-only; no placeholder-guard risk. CI test check passing (31479638284). Mergeable.

@argszero
argszero merged commit ac17ed4 into master Aug 11, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant