Skip to content

emrg: gen-assets — cygpath the wrapper HTML URL (Windows file:// fix) #706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
argszero merged 1 commit into from
Aug 12, 2026
Merged

emrg: gen-assets — cygpath the wrapper HTML URL (Windows file:// fix) #706

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion packaging/gen-assets.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,15 @@ render_svg_to_png() {
if [ -n "$chrome" ] && command -v "$chrome" >/dev/null 2>&1 || [ -x "$chrome" ] 2>/dev/null; then
echo " renderer: $chrome (headless, HTML wrapper, opaque white bg)"
HTML="$OUT/.icon-render.html"
# cygpath the wrapper page URL too — on Windows Git Bash $HTML is an MSYS
# path (/c/Users/...), and file:///c/Users/... (missing drive colon) fails
# to load in Chrome/Edge, silently rendering a blank opaque icon that the
# alpha check below cannot catch (white wrapper bg → colortype 2 "assumed
# opaque"). Same conversion as SVG_URL above. (empirically verified)
PAGE_URL="file://$HTML"
if command -v cygpath >/dev/null 2>&1; then
PAGE_URL="file:///$(cygpath -m "$HTML")"
fi
cat > "$HTML" <<HTMLEOF
<!DOCTYPE html><html><head><meta charset="utf-8">
<style>html,body{margin:0;padding:0;background:#fff}</style></head>
Expand All @@ -68,7 +77,7 @@ HTMLEOF
"$chrome" --headless --disable-gpu --hide-scrollbars --force-device-scale-factor=1 \
--allow-file-access-from-files \
--screenshot="$OUT/icon.png" --window-size=1024,1024 \
"file://$HTML" >/dev/null 2>&1
"$PAGE_URL" >/dev/null 2>&1
rm -f "$HTML"
return 0
fi
Expand Down
Loading