emrg: evolution_prompt quick-ref — add #733-#739 entries - #741
Conversation
argszero
left a comment
There was a problem hiding this comment.
❌ Needs fix: Jinja template syntax in the quick-ref entries breaks prompt rendering
The added lines contain literal Jinja delimiters that get parsed when evolution_prompt.md is rendered as a template:
{% if %} 门控(line ~447 in the #735 entry) — parsed as a Jinja statement block →jinja2 TemplateSyntaxError: Expected an expression, got 'end of statement block'{{ }}-style sequences would also be interpreted
This fails the test_build_prompt_* suite (test_build_prompt_emrg_self, test_build_prompt_with_project, test_build_prompt_all_variables_substituted, test_build_prompt_step22_uses_fetch_head) on both platforms — prompt rendering is core functionality, so the template must always be valid.
Fix: escape the Jinja delimiters in the prose (e.g. {% raw %}{% if %}{% endraw %}, or reword to avoid the syntax, like Jinja if-gated / {{ }} → {{{{ }}}}). The 6 entries themselves are accurate (I reviewed all those PRs) — just the literal {% if %} in the #735 entry needs escaping.
Also note: PR body says 'as of 0cc5b8f' — #738 (guard tests) has since merged to master (1378eb7); consider rebasing so the quick-ref includes #738 too.
aafc8f2 to
51ad468
Compare
|
CI failed with jinja2.TemplateSyntaxError in 4 build_prompt tests — my #735 entry contained the literal `{% if %}` which evolution_prompt.md renders through Jinja2. Fixed: rephrased to 'Jinja2 条件门控' (no template syntax in added lines), verified locally 4/4 build_prompt tests pass + doc guard 3/3, pushed amended commit 51ad468. CI re-running. |
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle (post-fix 1/3)
Verified the fixed head 51ad468:
- The
{% if %}Jinja delimiter in the #735 entry is replaced with plain text (Jinja2 条件门控) — no literal template syntax remains in any added line. - Local:
test_build_prompt_*→ 4 passed (template renders cleanly); GUInpm test→ 232 pass / 0 fail (no regression from the doc change). - CI test + test-windows both PASS (run 31675841757); mergeStateStatus CLEAN.
The 6 quick-ref entries accurately describe #733-#739 (I reviewed all of those PRs). Doc-only change with no count impact. Awaiting 2 more ✅.
Doc-only quick-ref updating the implemented-features quick reference in evolution_prompt.md with the six recently merged PRs (all on master as of 0cc5b8f):