emrg: GUI settings panel title + remove duplicate sidebar settings-btn (rant 21:49:51) - #773
Merged
Merged
Conversation
added 2 commits
August 13, 2026 22:14
…n (rant 21:49:51) The settings workspace view lacked a heading (Rant/Project/Task panels got theirs in the parallel panel-restyle) and the sidebar footer had a redundant '设置' button duplicating the nav gear entry. Changes: - index.html: add h2.workspace-view-title (data-i18n=settings.title) to #panel-settings; remove #settings-btn from .sidebar-footer (keep #status-dot connection indicator) - app.js: drop the dead settings-btn click binding - i18n.js: remove orphaned sidebar.settings keys (zh/en); settings.title already existed - layout.css: add .workspace-view-title styles (also styles the parallel panels' titles which referenced the class without a definition) - renderer.smoke +1 test (GUI 241→242, Agent.md synced 118 renderer smoke)
argszero
commented
Aug 13, 2026
argszero
left a comment
Owner
Author
There was a problem hiding this comment.
✅ LGTM — cycle (1/3)
Verified head 8a2d26b (6 files +32/-12 incl. symlink cleanup):
- index.html: settings panel gains h2.workspace-view-title[data-i18n=settings.title]; sidebar-footer keeps #status-dot only.
- app.js settings-btn binding removed; i18n.js sidebar.settings orphan keys removed (settings.title already existed in both locales).
- layout.css adds the .workspace-view-title definition — previously referenced by the parallel panels' titles with no CSS anywhere.
- renderer.smoke +1 (GUI 242, Agent.md synced 118 renderer smoke); pytest 801/801; CI test + test-windows PASS (run 31709155858).
argszero
commented
Aug 13, 2026
argszero
left a comment
Owner
Author
There was a problem hiding this comment.
✅ LGTM — cycle (2/3, head 8a2d26b)
Fresh independent verification this cycle (full-diff + greps on head):
- index.html: settings panel gains
<h2 class="workspace-view-title" data-i18n="settings.title">; sidebar-footer keeps only #status-dot (settings-btn removed). - app.js:
$("settings-btn")binding removed; nav-click path (switchView("settings")) still calls loadEvolutionSummary() + Dialogs.showSettings() — feature preserved, button was a true duplicate. - i18n.js: sidebar.settings orphan keys removed (zh+en); settings.title present in both locales (verified).
- layout.css: .workspace-view-title definition added (font-size/weight/color/margin) — used by the new settings heading.
- Full-tree grep: settings-btn → 0 refs, sidebar.settings → 0 refs.
- Agent.md 241→242 (+1 renderer smoke 117→118) consistent; CI test + test-windows PASS (run 31709155858); 3-dot diff = exactly 6 files +32/-10; mergeable.
One note: the layout.css comment says the class unifies settings/Rant/projects/tasks panel titles, but only the settings panel uses it so far (the other panels use .hint divs, no h2). Not dead code (it styles the new heading); fine as-is — the other panels can adopt it later.
argszero
commented
Aug 13, 2026
argszero
left a comment
Owner
Author
There was a problem hiding this comment.
✅ LGTM — cycle (3/3, fresh cycle)
Independent re-verification on head 8a2d26b vs master c9c400f:
- Diff = 6 files +32/-10: settings panel h2.workspace-view-title (data-i18n=settings.title), sidebar-footer keeps #status-dot only, app.js settings-btn binding removed, i18n sidebar.settings orphan keys removed (settings.title already existed in both locales), layout.css .workspace-view-title definition added (was referenced by parallel panels' titles without CSS).
- GUI suite 242/242 incl. new source-level test; pytest 801/801; CI test + test-windows PASS (run 31709155858).
- Merge gate satisfied: 3 consecutive ✅ from different cycles (14:16:22Z, 14:21:06Z, this one), no ❌.
argszero
added a commit
that referenced
this pull request
Aug 13, 2026
GUI settings-title entries (#775)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes host rant
2026-08-13T21:49:51: the settings workspace view had no heading (unlike the Rant/Project/Task panels getting.workspace-view-titlein the parallel panel restyle), and the sidebar footer carried a redundant 设置 button duplicating the nav gear entry.Changes:
index.html: add<h2 class="workspace-view-title" data-i18n="settings.title">设置</h2>to#panel-settings; remove#settings-btnfrom.sidebar-footer(keep#status-dotconnection indicator — it's independently useful)app.js: drop the dead\$"settings-btn"click bindingi18n.js: remove orphanedsidebar.settingskeys (zh/en);settings.titlealready existedlayout.css: add.workspace-view-titlestyles — the class was referenced by the parallel panels' titles without a definition anywhererenderer.smoke.test.js+1 test: settings title present in index.html source, no settings-btn in footer/JS/i18n (GUI 241→242, Agent.md synced 118 renderer smoke)Verified: GUI 242/242, pytest 801/801, import + CLI OK.