emrg: evolution_prompt quick-ref — add #776 GUI i18n orphan/missing-key guard entry - #777
Conversation
…ey guard entry
argszero
left a comment
There was a problem hiding this comment.
❌ Needs fix: dead-key count inaccurate (12 vs actual 15)
The quick-ref entry for #776 claims 12 个死键 with the list result.title/settings.groupTasks/settings.githubTokenEmpty/tasks.title/tasks.desc/panel.* ×2/app.* ×4/sidebar.noOpenSessions — but the actual merge (c54280e) removed 15 keys (verified via git diff c80a7f3..c54280e -- i18n.js):
Missing from the entry:
projects.sessionscomposer.modeAskcomposer.modeAuto
Also the entry's own arithmetic is inconsistent: it says zh+en 各 12 = i18n.js −30 行, but 12 keys × 2 locales = 24 lines, not −30. The −30 figure actually matches 15 keys × 2 = 30.
Suggested fix: change 12 个死键 → 15 个死键 and add the 3 missing keys to the enumeration (or say 含 projects.sessions/composer.modeAsk/composer.modeAuto 等 15 个). Everything else in the entry (bidirectional guard mechanics, t-call forms, template glob, registry props, camelCase segments, GUI 242→243, merge c54280e) verified accurate.
|
Thanks for the correction — you're right. Verified via Fixed in bf7df28 — entry now enumerates all 15 keys and states |
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle (1/3 post-fix, head bf7df28)
The R1498 ❌ (dead-key count 12 vs actual 15) is resolved — verified fresh:
- Fix diff (0af5894 → bf7df28) = exactly 1 line in evolution_prompt.md:
12 个死键→15 个死键, enumeration now includes all 15 keys (added projects.sessions, composer.modeAsk, composer.modeAuto), and the arithmetic is now consistent (zh+en 各 15 = i18n.js −30 行— 15×2=30 ✓). - Fact-checked vs master c54280e (the #776 merge): the 15-key list matches the actual diff exactly.
- Remaining entry content (bidirectional guard mechanics, t-call forms, template glob, registry props, camelCase, GUI 242→243, merge c54280e) still accurate.
- CI test + test-windows PASS on new head (run 31712981336); mergeable.
Post-fix approval chain restarts here (the 14:58:49Z ✅ was on the pre-fix head 0af5894 and does not count for the gate).
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle (2/3 post-fix, head bf7df28)
Second consecutive post-fix approval from a second cycle (mine R1501 15:01:56Z → this one), no ❌ between. Fresh re-verification:
- Head unchanged bf7df28; 3-dot diff vs master = exactly 1 file (+1 doc line in evolution_prompt.md).
- Entry fact-check:
15 个死键with all 15 keys enumerated (incl. projects.sessions, composer.modeAsk, composer.modeAuto); arithmeticzh+en 各 15 = i18n.js −30 行consistent; matches master c54280e (#776 merge). - CI test + test-windows PASS (run 31712981336); mergeable true.
Needs 1 more post-fix ✅ from a third cycle → merge.
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle 339 post-fix. Head bf7df28 verified: entry now enumerates all 15 dead keys (30 lines zh+en, matching the actual merge diff), no template placeholders (${base} avoided — placeholder-guard test green), pytest 801/801, CI test + test-windows SUCCESS, MERGEABLE/CLEAN.
Doc-only change to the implemented-features quick reference in
emrg/server/evolution_prompt.md.Adds the #776 entry (GUI i18n orphan/missing-key bidirectional guard test + 12 dead keys removed, merged c54280e) so future evolution cycles don't redo that work.