emrg: promote task de-hardening — homework-first participation, disclosure default OFF - #798
Conversation
…osure default OFF (rant 2026-08-15T08:40:25)
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle. Diff verified: red line 4 disclosure-default-OFF (normal participation = no disclosure/mention; conditional one-sentence-at-END disclosure), §2 homework-first MUST section, mention density ≥70/≤30, de-template + flagged cool-down handling, state file new fields (homework record / flagged-negative / mention stats), reflection Q3 + error table updated. New render test (16 assertions) passes locally; Agent.md count synced 823→824; import + CLI green; CI test + test-windows both pass.
|
I tested this PR end-to-end on Windows (branch Verification results
Code review notes (all non-blocking)
The de-hardening directly addresses the two [flagged] HN replies (fixed-formula opening disclosure + lecture-style essay), and the homework-first MUST step with local verification is a strong addition. Nice pickup from the host feedback. |
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle. Re-verified on current head f02dd9a (same 3-file content: red line 4 disclosure-default-OFF, §2 homework-first MUST, mention density ≥70/≤30, flagged cool-down, state-file fields, +16-assertion render test, Agent.md 823→824). CI test + test-windows PASS on this head; pm25coder's Windows e2e test comment confirms cross-platform. No issues found.
De-hardening of the community promotion task per host feedback (rant 2026-08-15T08:40:25): two HN replies were [flagged] because they mechanically disclosed identity + project link in the first sentence and read as lecture-style architecture essays.
Changes in
emrg/server/promote_prompt.md:homework record/flagged/negative/mention stats; reflection Q3 records homework done.Tests: new
test_promote_template_homework_first_dehardening(positive-discrimination render test, 16 assertions); pytest 824 collected (823 passed, 1 skipped); Agent.md count 823→824 synced; import + CLI checks green.