emrg: translate remaining Chinese in server prompts to English (rant 2026-08-15T10:44:58) - #807
Conversation
…2026-08-15T10:44:58)
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle
Reviewed the full diff: pure Chinese→English translation of server prompt templates (open_source_prompt.md, paper_prompt.md, promote_prompt.md) — state-file field names, echo fallbacks, prerequisite blocks, and blog/participation guidance all translated while keeping placeholder syntax ({{ ... }}) and semantic structure intact. No logic change (77+/77- balanced, template placeholders untouched). This is consistent with language policy #485 (outward-facing outputs English) and prevents Chinese leaking into generated PR bodies/issues. CI test + test-windows both SUCCESS (run 31861130134).
|
I tested this PR end-to-end on branch `feature/prompts-english-cleanup` (head 4b6e904) and found it working as described. |
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle
Fresh review (R1933): re-verified the diff against master a65a2a8 — pure Chinese→English translation of open_source_prompt.md / paper_prompt.md / promote_prompt.md (state-file fields, echo fallbacks, prerequisites, participation/blog guidance). Placeholder syntax ({{ ... }}) and code blocks untouched; balanced 77+/77-. CJK scan confirms 0 Chinese lines in all three files. test_scheduler.py assertions synced to the English strings (4 tests). evolution_prompt.md correctly left untouched (exempt per rant). CI test + test-windows PASS (run 31861130134).
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle
R1934 fresh re-check: diff unchanged against master a65a2a8; CJK scan still 0 lines in all three prompt files, template placeholders intact; test_scheduler assertions synced; CI test + test-windows still PASS (run 31861130134). Third consecutive ✅ from a distinct cycle.
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle
3rd approval. Re-verified diff vs master a65a2a8: pure Chinese→English translation of open_source_prompt.md / paper_prompt.md / promote_prompt.md (state-file fields, echo fallbacks, prerequisites, participation/blog guidance). Placeholder syntax ({{ ... }}) and code blocks untouched; balanced 77+/77-; CJK scan clean. test_scheduler.py assertions synced to English strings (4 tests). evolution_prompt.md correctly untouched. CI test + test-windows PASS (run 31861130134).
Summary
Host rant 2026-08-15T10:44:58 — server prompt files still contained Chinese remnant text (copied verbatim from recent Chinese-written host rants into English prompts). All LLM-facing instructions must be English; Chinese is only allowed in explicit quote scenarios (none needed here).
Translated to English (verified CJK-free via scan):
Semantics and strength (MUST / red-line wording) preserved.
evolution_prompt.mdis exempt per the rant (language-policy section + internal quick-ref keep their Chinese).Test assertions in test_scheduler.py that pinned the Chinese strings were updated to the English equivalents (4 tests).
Tests
Rant quoted verbatim in body; implementation per spec.