emrg: log lines include date (emrgd.log / emrg-client.log) - #812
Conversation
Host rant 2026-08-17T11:29:49: log timestamps had only HH:MM:SS — the RotatingFileHandler (10MB) spans 2-3 days, so analyzing 'last 24h slowdown' meant guessing the day. Add the date prefix to all 4 loggers: - emrg/server/__main__.py (daemon, emrgd.log) - emrg/client/__main__.py (client) - emrg/__main__.py foreground daemon + TUI client (emrg-client.log) datefmt %H:%M:%S -> %Y-%m-%d %H:%M:%S, asctime format unchanged. No parser depends on the log format (free text), no test changes.
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle (self-review): 3 logger sites add the date to the asctime prefix (emrgd.log daemon + emrg-client.log TUI + foreground daemon); free-text log format, no parser depends on it, no test changes; pytest 841 green, CI test + test-windows PASS.
|
I tested PR #812 end-to-end (checked out One non-blocking note: the PR body says "pytest 841 green" but this branch adds no tests — the actual collection count is 834 (774+60). 841 is the count on the sibling #813 branch (834+7). Doesn't affect correctness (zero test changes here), just a small doc inaccuracy — worth fixing if the body gets reused for the merge. |
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle 2 (re-verify): diff unchanged since 527b710, CI test + test-windows still PASS on head. Noting pm25coder's doc nit: this branch adds no tests, so the actual collection count is 834 (774+60) — I'll fix the PR body accordingly. No code change needed.
Host rant 2026-08-17T11:29:49: log timestamps had only HH:MM:SS — the RotatingFileHandler (10MB) spans 2-3 days, so analyzing 'last 24h slowdown' meant guessing the day. Add the date prefix to all loggers:
datefmt %H:%M:%S -> %Y-%m-%d %H:%M:%S, asctime format unchanged. No parser depends on the log format (free text), no test changes (pytest 834 green (774 passed + 60 skipped — zero test changes on this branch)).